1187394 - Move Backfill job link from Job details to Job details Action bar

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

Per the discussion in IRC, we'd like to move the current action for Backfill job, from the Job details pane (which mostly just presents information) to the Job details Action bar.

So we don't end up exceeding the action bar width, I pose we go with a drop down menu where:

- our current retrigger icon is the menu selector
- our current retrigger icon maintains its green hover behavior

And when the user clicks on the icon, instead of retriggering, we post a menu containing:

Retrigger job
Retrigger job on previous pushes*

* perhaps more informative than "Backfill" from a first time user perspective? I defer to you guys. If Backfill is a universally understood concept, then yah go with Backfill. I just didn't know precisely what it meant until I read the link title :)

Since we have 'r' as a shortcut for retrigger, I don't consider moving that function inside a menu as a UX issue. Users can use the shortcut if they wish.

Comment 1

[Jonathan French (:jfrench)]

Attachment: moveBackfillJobslink

Screen grab of current implementation, with proposed location.n

Comment 2

[Jonathan French (:jfrench)]

Vaibhav, curious were you planning on working on this as a follow up?

Comment 3

[Vaibhav (:vaibhav1994)]

:jfrench, I plan to work on this, but I am a bit occupied with another bug. You can take this up if you want :)

Comment 4

[Jonathan French (:jfrench)]

I'm getting close to a PR. I chatted with :kwierso in channel - he's indicated as a follow up we may want to either

a) provide a confirmation prompt for Backfilling or 
b) mimic the Save classification 'Save|>' UI cluster in the job details actionbar for Backfilling, so Backfill job is less 'selectable' (but which will consume more space in the actionbar) or
c) add a menu divider to the menu I'm planning to add, so "Retrigger job" and "Backfill job" are a little more separated during selection

Comment 5

[Jonathan French (:jfrench)]

Attachment: PR 958

PR for review :)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e4a24d4c1d9f8f46f3c7aba62a927d8c2e38fb11
Bug 1187394 - Move backfill ui to Job details actionbar

Comment 7

[Jonathan French (:jfrench)]

Marking fixed per above merge. Will verify on the next push to stage/prod :)

Comment 8

[Jonathan French (:jfrench)]

Verified fixed on production.