1187410 - XPCNativeInterface::NewInstance() leaks a string

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Andrew McCreight [:mccr8]]

When NewInstance() finds something that isn't usable in the child process it generates a console message using the following code:
            
char* intfNameChars;
aInfo->GetName(&intfNameChars);

However, it does not free |intfNameChars|, so we leak. The solution is to call GetNameShared() instead of GetName() which does not create copy of the string. |aInfo| should be alive for a long as we need the string (eg the next line) so that should be okay.

This was found by LSan, and shows up in various e10s tests, mostly bc, like toolkit/components/perfmonitoring/tests/browser/ and toolkit/components/addoncompat/tests/browser/.

(This is a regression from bug 997325.)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Use GetNameShared() in XPCNativeInterface::NewInstance() to avoid a leak.

I haven't done a full try run yet, but this seems pretty benign.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23952da58da6

Comment 3

[Andrew McCreight [:mccr8]]

try runs:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9cbdc870e3a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6822f4387e1e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/23952da58da6