Bookmarks should use default favicon if none is available

RESOLVED FIXED

Status

()

Firefox for iOS
Theme & Visual Design
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: darrin, Assigned: karim)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios+)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
In the bookmarks home panel, rather than showing nothing if a favicon is unavailable, we should show the globe icon used in other lists.
(Assignee)

Updated

3 years ago
Assignee: nobody → kbenhmida
(Assignee)

Comment 1

3 years ago
Created attachment 8639567 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/812
Attachment #8639567 - Flags: review?(sleroux)
Comment on attachment 8639567 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/812

See review comment, then make sure it works. Ping if you need one of us to merge.
Attachment #8639567 - Flags: review?(sleroux) → review+
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Merged PR: https://github.com/mozilla/firefox-ios/commit/881183260fc7a932609b1753e13e56372e55af90
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
tracking-fxios: ? → +
You need to log in before you can comment on or make changes to this bug.