1187526 - [Search] Search bar will move to the top of the screen if the user begins to pull down utility tray or taps at top of screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
When the user has the search bar active and taps the top of the screen or pulls down the utility tray they will see the search bar move to the top of the screen.

Repro Steps:
1) Update a Aries to 20150724113133
2) Tap on the search bar on the homescreen
3) Tap the top of the screen
5) Observe search bar

Actual:
The search bar moves to the top of the screen

Expected:
It is expected that the search bar will not move to the top of the screen.

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150724113133
Gaia: db299103dd17a873cba4ff88e62ec173bf80fe62
Gecko: 9bca608ab65a
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
See attached: video clip(https://youtu.be/oMuGV45o9C0), logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES affect Flame 2.5.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
BuildID: 20150724010206
Gaia: ec2199b324304d3678b6a98a08a31bdc13c9e984
Gecko: cb8bdb8ffaef
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Result:
The search bar moves to the top of the screen
----------------------------------
This issue DOES NOT occur on Flame 2.2.

Environmental Variables:
Device: Flame 2.2 [Full Flash]
BuildID: 20150724002505
Gaia: e1e6317f17a840b19af9dbb25f5a771d8d9fa161
Gecko: 4cff5605633b
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Result:
the search bar does not move to the top of the screen.

Comment 2

[Oliver Nelson [:oliverthor]]

Not nominating for block as it seems like a polish issue, minor UI issue that recovers quickly.
Adding regressionwindow-wanted

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

B2G Inbound

Last Working
Device: Flame 2.5
BuildID: 20150709105424
Gaia: 73ece50d39e5949a5eaa942820300cd23a4c3f7c
Gecko: 6eb389866758
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

First Broken
Device: Flame 2.5
BuildID: 20150709115322
Gaia: 31eed4c0ab1a32f1a5bf8acac723595b61902027
Gecko: 81af3a741875
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 73ece50d39e5949a5eaa942820300cd23a4c3f7c
Gecko: 81af3a741875

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 31eed4c0ab1a32f1a5bf8acac723595b61902027
Gecko: 6eb389866758

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/73ece50d39e5949a5eaa942820300cd23a4c3f7c...31eed4c0ab1a32f1a5bf8acac723595b61902027

This might have been caused by the work done for Bug 1177477

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Alberto, ca you take a look at this please? This might have been caused by the landing for bug 1177477.

Comment 5

[Alberto Pastor [:albertopq]]

[Blocking Requested - why for this release]: Broken UI. Regreesion

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1187526-search-top > mozilla-b2g:master

Comment 7

[Alberto Pastor [:albertopq]]

Comment on attachment 8642932 [details] [review]
[gaia] albertopq:1187526-search-top > mozilla-b2g:master

Hey Kevin, how do you feel about moving the rocketbar outside the statusbar div? The transformations we are doing to the statusbar are affecting to the rocketbar when they shouldn't. Thanks!

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8642932 [details] [review]
[gaia] albertopq:1187526-search-top > mozilla-b2g:master

Hmm, I'm surprised this worked as well as it did :) It seems to have worked ok to me, but I am sure that there will be a few regressions from it, potentially from animations inside of fullscreen apps. (I noticed that the rocketbar will slide to a close when there is no background, but I do think that it's an acceptable loss.)

Just to be sure, I'd like etienne to review this as well, since he reviewed bug 1177477. Thanks!

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8642932 [details] [review]
[gaia] albertopq:1187526-search-top > mozilla-b2g:master

Always hated that the rocketbar was there \o/

We need to be on the look out for regressions still, like Kevin said.

I did a fair amount of manual testing on my end and found nothing, lets triple check that the marionette test are a-ok.
And then land!

Worse case scenario, it's a really easy backout :)

Comment 10

[Gregor Wagner [:gwagner]]

Is this ready to land?

Comment 11

[Alberto Pastor [:albertopq]]

Just rebased. Let's wait for treeherder green and I'll land it.

Comment 12

[Alberto Pastor [:albertopq]]

Gaia is closed. Michael, could you please land it when is open again? Thanks!

Comment 13

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/86eab1fd117501f499c67588021ed905498ec01c

Comment 14

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Search bar will close and not move to the top of the screen when the user begins to pull down utility tray or taps at top of screen.
See attachment: verified_Aries_v2.5.3gp
Reproduce rate: 0/15


Device: Flame KK 2.5 (Pass)
Build ID               20150811150203
Gaia Revision          2d7f369fd923b6df3b00d76844c413c1202c04ba
Gaia Date              2015-08-11 09:58:44
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/38c1ea9ccae31700630f1fe0d651e94c0c5b9e1d
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150811.182056
Firmware Date          Tue Aug 11 18:21:06 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150811234258
Gaia Revision          c7875bbc8b32e7b95cc55c9690b03b140905d84d
Gaia Date              2015-08-11 18:18:36
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d4f3a8a75577e4af2914a4e899ca2e724f9715c4
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150811.230622
Firmware Date          Tue Aug 11 23:06:29 UTC 2015
Bootloader             s1

Comment 15

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_v2.5.3gp