1187555 - Convert callbacks in worker_test.js into Promises

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1044984 +++

We should use Promises and Promise chain to describe a series of async test operations, and worker_test.js do exactly that.

If you could like to take this bug, you would need to figure out how to run the test locally, and understand Promise and how Promise chain work with mocha (hint: |grep| other tests).

Please also read Julien's comment here:
https://github.com/mozilla-b2g/gaia/pull/31070.
Which is a pull request of bug 1044984. The comment on the bug should also help you understand what the test do to assert the output or worker.js.

Comment 1

[anubhav.worklinux]

Hi, i would like to work on this bug. i read Julien's comments on your bug to make the tests promise based. Would submit a patch soon.
thanks!

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks!

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] anu7495:my-fix > mozilla-b2g:master

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8643505 [details] [review]
[gaia] anu7495:my-fix > mozilla-b2g:master

Nice! The patch need one more improvement:

1. Let's change the name of the function passed from mocha from |next| to |done| for consistency.
2. The prediction() function can also be a function that returns a promise, instead of take a callback.

I am not sure if prediction() is the only async function left in the file that takes callbacks. But the goal of this bug is to convert async function pattern to promises so we should convert all of them.

Thank you!

Comment 5

[anubhav.worklinux]

Comment on attachment 8643505 [details] [review]
[gaia] anu7495:my-fix > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/31250

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8643505 [details] [review]
[gaia] anu7495:my-fix > mozilla-b2g:master

I've left a comment on GitHub. Looks like a good progress but there is a common Promise pitfall on prediction(). I hope my explanation is clear enough there.

Thanks!

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8643505 [details] [review]
[gaia] anu7495:my-fix > mozilla-b2g:master

Thanks for the patch. Please update the patch according to the two comments before asking for check-in.

Comment 8

[anubhav.worklinux]

Thanks!
Will make the changes and ask for check-in soon.
Thanks again.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/e3b15bd8607686438f394d491d5ab0372fc09d70