1187605 - Dropdown arrow in vertical writing modes should point in the appropriate (sideways) direction

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jonathan Kew [:jfkthame]]

Bug 1172450 will make dropdown arrows visible in HTML <select> elements in vertical writing mode, but they'll all be pointing downwards. The arrow should point leftwards for writing-mode:vertical-rl, and rightwards for vertical-lr.

If it's helpful, I think we could make the layout code add an attribute such as 'orientation' to the button in vertical writing modes; then theme CSS could match this to choose an appropriate transform or an alternative graphic asset.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: pt 1 - In vertical writing modes, add an 'orientation' attribute with value='left' or 'right' to the <select> control's dropdown button

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: pt 2 - Make the <select> dropdown arrow respect the 'orientation' attribute, if present

Comment 3

[Jonathan Kew [:jfkthame]]

Moving this to core:layout as that's where it is actually implemented. I suppose front-end themes might want to style things differently, but the basic behavior is here at least.

Comment 4

[Jonathan Kew [:jfkthame]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3a38462c5703ebb5a2586cb0ad6a8318355265b3
changeset:  3a38462c5703ebb5a2586cb0ad6a8318355265b3
user:       Jonathan Kew <[e-mail]>
date:       Mon Aug 03 18:45:20 2015 +0100
description:
Bug 1187605 pt 1 - In vertical writing modes, add an 'orientation' attribute with value='left' or 'right' to the <select> control's dropdown button. r=smontagu

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/8ad982618f06bad91d4c712b55803359d746863c
changeset:  8ad982618f06bad91d4c712b55803359d746863c
user:       Jonathan Kew <[e-mail]>
date:       Mon Aug 03 18:45:24 2015 +0100
description:
Bug 1187605 pt 2 - Make the <select> dropdown arrow respect the 'orientation' attribute, if present. r=smontagu

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a38462c5703
https://hg.mozilla.org/mozilla-central/rev/8ad982618f06

Comment 6

[Gérard Talbot]

Tests for this bug report
-------------------------

http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/form-controls-vrl-004.htm

http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/form-controls-vlr-004.htm

http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/form-controls-srl-004.htm

http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/form-controls-slr-004.htm