11877 - Pages with charsets fail to display in viewer, and the editor

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Simon Fraser [no longer active]]

Loading a page with a charset declaration in either viewer, or the editor
window (via Edit page) fails; the webshell is left in a bad state where
nothing draws.

The reason this happens is that nsObserverBase::NotifyWebShell()
turns off rendering with wss->SetRendering(PR_FALSE), then tells
the webShell to reload the docment wss->ReloadDocument(charset, source).

However, nsWebShell::ReloadDocument() only does the reload if there is
session history around to get the URL from. This does not work in viewer, and
in the editor window, where there is no session history.

So, somehow, it seems that nsWebShell::ReloadDocument() has to be able to
function even if there is no session history (or perhaps there should be a
length-1 history list in all webshells?)

The issue of charset detection forcing a reload is also open for debate, and
the topic of other bugs.

Comment 1

[Simon Fraser [no longer active]]

cc webshell owner nisheeth

Comment 2

[Radha on family leave (not reading bugmail)]

*** This bug has been marked as a duplicate of 11577 ***

Comment 3

[Radha on family leave (not reading bugmail)]

This is not a dup of 11577. I have a fix for this and will attempt to fix for M9

Comment 4

[Frank Tang]

Maybe the right fix is just use the mURL as the URL without getting the URL from
the history. And deal with the "back" problem seperately. There are no reason we
cannot use mURL but have to use the one from the history, right ? I think the
origional code I put down by using hisotry is done before the mURL is there. (or
simply because I am too stupid that didn't know there is a mURL around that I
can use.)

Comment 5

[don]

Radha, do you plan to land this on the branch with rpotts' changes?

Comment 6

[Radha on family leave (not reading bugmail)]

I managed to check this in yesterday. marking fixed.

Comment 7

[rubydoo123]

marking verified using the 1999082016 on win95 and mac

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/683cc6a08281
[components] Close https://github.com/mozilla-mobile/android-components/issues/11877: Add support to sanitize intent