1187725 - Addons: Ignore missing localizations for em:name

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Christian Stadelmann]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150708165822

Steps to reproduce:

0. start a localized version of firefox for German (de) or Italian (it)
1. Install addon "Certificate Patrol" from https://addons.mozilla.org/en-US/firefox/addon/certificate-patrol/
2a. go to about:addons
2b. go to about:support

Alternative steps 0. and 1.:
0. you need firefox localized for any non-English locale, but don't start it yet
1. edit any installed addon with localization:
1.1. open .xpi file
1.2. edit install.rdf file
1.3. go to your localization (em:localized tag)
1.4. below Description, delete the tag em:name
1.5. save .rdf file
1.6. save .xpi file
1.7. start firefox
continue with 2a or 2b from above


Actual results:

2a.: addon name is printed as "null" instead of the name

2b.: most fields on about:support are empty, rendering it useless

I get exceptions on stdout like this:

1437933373494	addons.manager	WARN	Exception calling callback: TypeError: a.name is null (resource://gre/modules/Troubleshoot.jsm:207:12) JS Stack trace: extensions/</<@Troubleshoot.jsm:207:13 < extensions/<@Troubleshoot.jsm:204:7 < [e-mail]:173:5 < [e-mail]:2236:9 < [e-mail]:305:7 < [e-mail]:2231:11 < this.Experiments.PreviousExperimentProvider.prototype<[e-mail]:2287:7 < [e-mail]:235:12 < [e-mail]:2226:1 < [e-mail]:311:7 < [e-mail]:2231:11 < [e-mail]:139:7 < [e-mail]:235:12 < [e-mail]:2226:1 < [e-mail]:311:7 < [e-mail]:2231:11 < [e-mail]:592:7 < [e-mail]:235:12 < [e-mail]:2226:1 < [e-mail]:311:7 < [e-mail]:2231:11 < [e-mail]:446:7 < [e-mail]:235:12 < [e-mail]:2226:1 < [e-mail]:311:7 < [e-mail]:2231:11 < [e-mail]:1027:7 < [e-mail]:235:12 < [e-mail]:2226:1 < [e-mail]:311:7 < [e-mail]:2231:11 < [e-mail]:3837:7 < makeSafe/<@XPIProviderUtils.js:145:17 < [e-mail]:180:7 < [e-mail]:187:9 < [e-mail]:134:5 < this.AddonRepository.getCachedAddonByID<@AddonRepository.jsm:575:7


Expected results:

If you consider a missing em:name tag below em:localized Description a bug, this addon should not be accepted by firefox.

I don't consider this a bug, instead I think firefox should use the non-localized em:name instead.

Comment 1

[Christian Stadelmann]

Note that this breaks the addon-manager too. If you installed an older version of "Certificate Patrol" on a German or Italian firefox installation and try to update, it won't do so. Instead you see this exception printed to stdout/stderr:

*************************
A coding exception was thrown and uncaught in a Task.

Full message: TypeError: aAddon._repositoryAddon is null
Full stack: loadManifest_getCachedAddonByID@resource://gre/modules/addons/XPIProvider.jsm:5273:13
this.AddonRepository.getCachedAddonByID<@resource://gre/modules/addons/AddonRepository.jsm:575:7
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
TaskImpl@resource://gre/modules/Task.jsm:275:3
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
loadManifest_cacheAddons@resource://gre/modules/addons/XPIProvider.jsm:5271:11
AddonRepo_cacheAddons@resource://gre/modules/addons/AddonRepository.jsm:682:9
loadManifest_getCachedAddonByID@resource://gre/modules/addons/XPIProvider.jsm:5270:1
this.AddonRepository.getCachedAddonByID<@resource://gre/modules/addons/AddonRepository.jsm:575:7
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
TaskImpl@resource://gre/modules/Task.jsm:275:3
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
addRepositoryData@resource://gre/modules/addons/XPIProvider.jsm:5259:7
AI_loadManifest@resource://gre/modules/addons/XPIProvider.jsm:5340:5
AI_onStopRequest@resource://gre/modules/addons/XPIProvider.jsm:5579:11

*************************

Comment 2

[Christian Stadelmann]

This issue is gone in Firefox 46.0.1.