1187785 - Interpolation between band-limited PeriodicWave tables is reversed

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Karl Tomlinson (:karlt)]

This is a regression from
https://hg.mozilla.org/mozilla-central/rev/b39629d18e66#l1.22
but the problem is that waveDataForFundamentalFrequency() is not consistent
with its documentation.  tableInterpolationFactor should be zero when using
lowerWaveData, which is when pitchRange is rangeIndex2.
https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/dom/media/webaudio/blink/PeriodicWave.cpp#l146

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: test periodic wave band limiting

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: reverse tableInterpolationFactor to make it consistent with documentation

tableInterpolationFactor = 0 now means use lowerWaveData, which is
rangeIndex2.

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8639138 [details] [diff] [review]
reverse tableInterpolationFactor to make it consistent with documentation

Review of attachment 8639138 [details] [diff] [review]:
-----------------------------------------------------------------

This code remains quite confusing! Seems to be consistent with both comments now.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2c005a1936d
https://hg.mozilla.org/integration/mozilla-inbound/rev/161362ba8d68

Comment 5

[Karl Tomlinson (:karlt)]

(In reply to Ralph Giles (:rillian) from comment #3)
> This code remains quite confusing! Seems to be consistent with both comments
> now.

Yes, sorry this hasn't helped much.  At least there's now a test.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e2c005a1936d
https://hg.mozilla.org/mozilla-central/rev/161362ba8d68

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5ca4b65694e

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f5ca4b65694e

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f5ca4b65694e