Closed
Bug 1187801
Opened 9 years ago
Closed 8 years ago
iframe with explicit fullscreen request should not exit fullscreen implicitly
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla44
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
This was a spec bug, described in https://www.w3.org/Bugs/Public/show_bug.cgi?id=28460
Assignee | ||
Comment 1•8 years ago
|
||
Bug 1187801 part 1 - Rewrite nsDocument::RestorePreviousFullScreenState() to unify logic of reverting element in parent document.
Attachment #8670692 -
Flags: review?(bugs)
Assignee | ||
Comment 2•8 years ago
|
||
Bug 1187801 part 2 - Put clearning fullscreen state on element into an independent function.
Attachment #8670693 -
Flags: review?(bugs)
Assignee | ||
Comment 3•8 years ago
|
||
Bug 1187801 part 3 - Add iframe fullscreen flag and stop auto-rollback when this flag presents.
Attachment #8670694 -
Flags: review?(bugs)
Assignee | ||
Comment 4•8 years ago
|
||
Bug 1187801 part 4 - Add test for iframe fullscreen flag.
Attachment #8670696 -
Flags: review?(bugs)
Updated•8 years ago
|
Attachment #8670692 -
Flags: review?(bugs) → review+
Updated•8 years ago
|
Attachment #8670693 -
Flags: review?(bugs) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8670694 [details] MozReview Request: Bug 1187801 part 3 - Add iframe fullscreen flag and stop auto-rollback when this flag presents. Increases the sizeof HTMLIframeElement I think. Could we perhaps put the flag (but not the relevant methods) to nsGenericHTMLFrameElement. It has still some spare bits.
Attachment #8670694 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #5) > Comment on attachment 8670694 [details] > MozReview Request: Bug 1187801 part 3 - Add iframe fullscreen flag and stop > auto-rollback when this flag presents. > > Increases the sizeof HTMLIframeElement I think. > Could we perhaps put the flag (but not the relevant methods) to > nsGenericHTMLFrameElement. It has still some spare bits. OK, will do so.
Comment 7•8 years ago
|
||
Comment on attachment 8670696 [details] MozReview Request: Bug 1187801 part 4 - Add test for iframe fullscreen flag. gTestSteps = [ // innerRoot [["enter", innerRoot], [iframe, innerRoot]], needs some comment what the different arrays and items in them are.
Attachment #8670696 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 8•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae7d6d7ded91
Assignee | ||
Comment 9•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecd8d7abd47f791c413df3d50fa0b10f01f1c204 Bug 1187801 part 1 - Rewrite nsDocument::RestorePreviousFullScreenState() to unify logic of reverting element in parent document. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/e9a3138359cdef0b3145299b653ba201e03b721b Bug 1187801 part 2 - Put clearing fullscreen state on element into an independent function. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/6f4888e3c8fc5416fb521966e213281b11ccca52 Bug 1187801 part 3 - Add iframe fullscreen flag and stop auto-rollback when this flag presents. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/56a0fe7a7dfea10842fe051a8305dc9e052456dd Bug 1187801 part 4 - Add test for iframe fullscreen flag. r=smaug
Comment 10•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ecd8d7abd47f https://hg.mozilla.org/mozilla-central/rev/e9a3138359cd https://hg.mozilla.org/mozilla-central/rev/6f4888e3c8fc https://hg.mozilla.org/mozilla-central/rev/56a0fe7a7dfe
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → quanxunzhen
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•