iframe with explicit fullscreen request should not exit fullscreen implicitly

RESOLVED FIXED in Firefox 44

Status

()

defect
RESOLVED FIXED
4 years ago
2 months ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

(Blocks 1 bug)

Trunk
mozilla44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 affected, firefox44 fixed)

Details

Attachments

(4 attachments)

Assignee

Updated

4 years ago
Blocks: 743198
Assignee

Comment 1

4 years ago
Bug 1187801 part 1 - Rewrite nsDocument::RestorePreviousFullScreenState() to unify logic of reverting element in parent document.
Attachment #8670692 - Flags: review?(bugs)
Assignee

Comment 2

4 years ago
Bug 1187801 part 2 - Put clearning fullscreen state on element into an independent function.
Attachment #8670693 - Flags: review?(bugs)
Assignee

Comment 3

4 years ago
Bug 1187801 part 3 - Add iframe fullscreen flag and stop auto-rollback when this flag presents.
Attachment #8670694 - Flags: review?(bugs)
Assignee

Comment 4

4 years ago
Bug 1187801 part 4 - Add test for iframe fullscreen flag.
Attachment #8670696 - Flags: review?(bugs)
Attachment #8670692 - Flags: review?(bugs) → review+
Attachment #8670693 - Flags: review?(bugs) → review+
Comment on attachment 8670694 [details]
MozReview Request: Bug 1187801 part 3 - Add iframe fullscreen flag and stop auto-rollback when this flag presents.

Increases the sizeof HTMLIframeElement I think.
Could we perhaps put the flag (but not the relevant methods) to nsGenericHTMLFrameElement. It has still some spare bits.
Attachment #8670694 - Flags: review?(bugs) → review+
Assignee

Comment 6

4 years ago
(In reply to Olli Pettay [:smaug] from comment #5)
> Comment on attachment 8670694 [details]
> MozReview Request: Bug 1187801 part 3 - Add iframe fullscreen flag and stop
> auto-rollback when this flag presents.
> 
> Increases the sizeof HTMLIframeElement I think.
> Could we perhaps put the flag (but not the relevant methods) to
> nsGenericHTMLFrameElement. It has still some spare bits.

OK, will do so.
Comment on attachment 8670696 [details]
MozReview Request: Bug 1187801 part 4 - Add test for iframe fullscreen flag.

  gTestSteps = [
    // innerRoot
    [["enter", innerRoot], [iframe, innerRoot]],

needs some comment what the different arrays and items in them are.
Attachment #8670696 - Flags: review?(bugs) → review+
Assignee

Comment 9

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecd8d7abd47f791c413df3d50fa0b10f01f1c204
Bug 1187801 part 1 - Rewrite nsDocument::RestorePreviousFullScreenState() to unify logic of reverting element in parent document. r=smaug

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9a3138359cdef0b3145299b653ba201e03b721b
Bug 1187801 part 2 - Put clearing fullscreen state on element into an independent function. r=smaug

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f4888e3c8fc5416fb521966e213281b11ccca52
Bug 1187801 part 3 - Add iframe fullscreen flag and stop auto-rollback when this flag presents. r=smaug

https://hg.mozilla.org/integration/mozilla-inbound/rev/56a0fe7a7dfea10842fe051a8305dc9e052456dd
Bug 1187801 part 4 - Add test for iframe fullscreen flag. r=smaug
Assignee

Updated

4 years ago
Depends on: 1213168
Assignee

Updated

4 years ago
Assignee: nobody → quanxunzhen
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.