1187801 - iframe with explicit fullscreen request should not exit fullscreen implicitly

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

This was a spec bug, described in https://www.w3.org/Bugs/Public/show_bug.cgi?id=28460

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1187801 part 1 - Rewrite nsDocument::RestorePreviousFullScreenState() to unify logic of reverting element in parent document.

Bug 1187801 part 1 - Rewrite nsDocument::RestorePreviousFullScreenState() to unify logic of reverting element in parent document.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1187801 part 2 - Put clearning fullscreen state on element into an independent function.

Bug 1187801 part 2 - Put clearning fullscreen state on element into an independent function.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1187801 part 3 - Add iframe fullscreen flag and stop auto-rollback when this flag presents.

Bug 1187801 part 3 - Add iframe fullscreen flag and stop auto-rollback when this flag presents.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1187801 part 4 - Add test for iframe fullscreen flag.

Bug 1187801 part 4 - Add test for iframe fullscreen flag.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8670694 [details]
MozReview Request: Bug 1187801 part 3 - Add iframe fullscreen flag and stop auto-rollback when this flag presents.

Increases the sizeof HTMLIframeElement I think.
Could we perhaps put the flag (but not the relevant methods) to nsGenericHTMLFrameElement. It has still some spare bits.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

(In reply to Olli Pettay [:smaug] from comment #5)
> Comment on attachment 8670694 [details]
> MozReview Request: Bug 1187801 part 3 - Add iframe fullscreen flag and stop
> auto-rollback when this flag presents.
> 
> Increases the sizeof HTMLIframeElement I think.
> Could we perhaps put the flag (but not the relevant methods) to
> nsGenericHTMLFrameElement. It has still some spare bits.

OK, will do so.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8670696 [details]
MozReview Request: Bug 1187801 part 4 - Add test for iframe fullscreen flag.

  gTestSteps = [
    // innerRoot
    [["enter", innerRoot], [iframe, innerRoot]],

needs some comment what the different arrays and items in them are.

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae7d6d7ded91

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ecd8d7abd47f791c413df3d50fa0b10f01f1c204
Bug 1187801 part 1 - Rewrite nsDocument::RestorePreviousFullScreenState() to unify logic of reverting element in parent document. r=smaug

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9a3138359cdef0b3145299b653ba201e03b721b
Bug 1187801 part 2 - Put clearing fullscreen state on element into an independent function. r=smaug

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f4888e3c8fc5416fb521966e213281b11ccca52
Bug 1187801 part 3 - Add iframe fullscreen flag and stop auto-rollback when this flag presents. r=smaug

https://hg.mozilla.org/integration/mozilla-inbound/rev/56a0fe7a7dfea10842fe051a8305dc9e052456dd
Bug 1187801 part 4 - Add test for iframe fullscreen flag. r=smaug

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ecd8d7abd47f
https://hg.mozilla.org/mozilla-central/rev/e9a3138359cd
https://hg.mozilla.org/mozilla-central/rev/6f4888e3c8fc
https://hg.mozilla.org/mozilla-central/rev/56a0fe7a7dfe