1187832 - [B2G][ICC] Do not notify for "SEND XXX" STK commands when the alpha identifier is a null object.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Samael Wang [:freesamael] (away for now)]

According to |6.4.10 SEND SHORT MESSAGE| of |ETSI TS 102 223| [1], the notification shouldn't be brought up to the user if the alpha identifier is a null object.

> * if the alpha identifier is provided by the UICC and is a null data object (i.e. length = '00' 
> and no value part), this is an indication that the terminal should not give any information to 
> the user on the fact that the terminal is sending a short message;
> 
> * if the alpha identifier is not provided by the UICC, the terminal may give information to the 
> user concerning what is happening.

The same behavior applies to "Send DTMF", "Send SS", and "Send USSD". The current implementation kind of mixed up the cases of "alpha identifier is not provided" and "alpha identifier is a null object", and triggers notifications incorrectly. We should avoid sending system messages if the alpha identifier is a null object.

[1] http://www.etsi.org/deliver/etsi_ts/102200_102299/102223/12.02.00_60/ts_102223v120200p.pdf

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Udpate bug title because STK commands are delivered over both dom events and system messages.

Comment 2

[Samael Wang [:freesamael] (away for now)]

Attachment: Update ril_worker and corresponding test cases

Comment 3

[Samael Wang [:freesamael] (away for now)]

Attachment: (v2) Update ril_worker and corresponding test cases

Comment 4

[Samael Wang [:freesamael] (away for now)]

Attachment: (v3) Update ril_worker and corresponding test cases

Comment 5

[Samael Wang [:freesamael] (away for now)]

Comment on attachment 8642867 [details] [diff] [review]
(v3) Update ril_worker and corresponding test cases

Hi Bevis,

Could you help to review the patch?

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8642867 [details] [diff] [review]
(v3) Update ril_worker and corresponding test cases

Review of attachment 8642867 [details] [diff] [review]:
-----------------------------------------------------------------

Please see my comment inline.

::: dom/system/gonk/ril_worker.js
@@ +9692,5 @@
> +    if (textMsg.text !== "") {
> +      // Icon identifier is optional.
> +      this.appendIconIfNecessary(selectedCtlvs[COMPREHENSIONTLV_TAG_ICON_ID] || null,
> +                                 textMsg,
> +                                 onComplete);

We should not suppress the notification of the user case that the alphaId is not available but the icon is available to be displayed.
Please also have this user case available in our test coverage.

Thanks!

Comment 7

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8642867 [details] [diff] [review]
(v3) Update ril_worker and corresponding test cases

Review of attachment 8642867 [details] [diff] [review]:
-----------------------------------------------------------------

Per offline discussion,
It seems to be my misunderstanding.
The availability of AlphaId is the first priority to display this notification according to the standard.
Thanks!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/a29e9b59c7f5

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a29e9b59c7f5