1187911 - Notifications repeat even when I clear them

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P2)

Description

[Sheeri Cabral [:sheeri]]

I get notifications over and over, even after clearing them. Including stuff that started 12 minutes ago. 

Do I need to open the calendar or something to register that yes, I saw this notification? I have notifications set for 10 min before a meeting only. 

I get that one, but then I get ones after that, that I don't set - for example, a meeting that started at noon my time, I got a notification at 11:50, but then at 12:02 as well. I've gotten notifications for meetings that started 30 minutes ago, and it's a repeat, not a delay in my IM service.

Not sure if this is related to bug 930794 but I see that's closed. Hardware is Sony Xperia Z3, build identifier 20150709163311.

Comment 1

[:gerard-majax]

Not that I don't want to admit bugs, but I have a good feeling this is more a Calendar-app issue rather than a System app or Gecko bug. Let's wait some more logs to check :)

Comment 2

[Sheeri Cabral [:sheeri]]

Attachment: 2015-07-28-15-29-58.zip

This problem manifested itself today. As you can see, I got a notification at 3:29 pm local time (Eastern) for a meeting called "Bi-weekly MOC/Data Service Review" but this meeting started at 3 pm. I got the reminder before the meeting and cleared it, but still got this one, as the meeting was ending. 

The logs are here.

Comment 3

[Sheeri Cabral [:sheeri]]

Attachment: screen shot of event on calendar

AFter I sent the logs, I clicked through the notification on my phone and took a screenshot - you can see that I have one reminder set, 10 minutes *before* the meeting - which I received and cleared, so it's not a notification/messaging delay - and the meeting started at 3 pm - the notification is 3:29 pm.

Other details - this is my Google Calendar associated with work - I also sync a personal Google Calendar with my phone. Only the work calendar exhibits this behavior, and it's sporadic (I had other meetings yesterday and today and the notifications were only 10m ahead of time as expected).

The notifications after the meeting starts are seemingly random - sometimes they're 10 minutes after, I've seen 45 minutes after....this one was 29 minutes after.

Hope the logs and screenshot help.

Comment 4

[:gerard-majax]

Thanks.

> 07-28 15:29:13.629 25885 25885 I Calendar: Content JS LOG: controllers/notifications [calendar]  "Will send event notification with title:" "Bi-weekly MOC/Data Service Review started 29 minutes ago" "body:" "Please find the rolling agenda here:\nhttps://docs.google.com/a/mozilla.com/document/d/1M6YFvjz2DwmyCywilXPD4rTSohcHex9dUcMkGuoLylo/edit?usp=sharing" 

Given the description and the timestamp, this exactly looks like the one you got 29 minutes after. That code is Calendar app.

Comment 5

[Dylan Oliver [:doliver]]

[Blocking Requested - why for this release]:

Comment 6

[Mahendra Potharaju [:mahe]]

Blocked for 2.5. Need to identify exact STR.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] gaye:bug-1187911-repeat-notifications > mozilla-b2g:master

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31951

I haven't tested this out on a device yet, so I'll hold off on landing until I go for that. The strategy is simply to add a flag to each alarm that tells the calendar app that we've already issued a notification for it once we send the first notification. Then we check that flag before sending notifications to prevent the case where we issue multiple notifications for a single alarm.

Comment 9

[James Burke [:jrburke]]

Comment on attachment 8663780 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31951

Commented in pull request, flip back to review when the cleanup question is addressed, even if it is just an explanation of how it is cleaned up given the operation of the stores.

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8663780 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31951

Updated to make sure we map back data that roundtrips through alarms api to latest data in indexeddb.

Comment 11

[James Burke [:jrburke]]

Comment on attachment 8663780 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31951

r+ by inspection, discussion in IRC.

Comment 12

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/d03f6b2dae2499e0771a2607b5d4c17dcd53b54d landed on master