1187939 - bzexport fails on bugs with no description

Status: RESOLVED FIXED

(Developer Services :: Mercurial: bzexport, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

For a patch where the description reads like:

Bug xxxxxx. r=somebody

bzexport fails in:

  File "/home/morbo/.mozbuild/version-control-tools/hgext/bzexport/__init__.py", line 873, in bzexport
    if desc[-1] in [';', '.']:

It's fairly typical for security bugs not to have a description outside (nonpublic) Bugzilla.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bzexport: guard against empty description (bug 1187939); r?smacleod

bzexport: guard against empty description (bug 1187939); r?smacleod

Apparently the description can be empty for e.g. security bugs. I didn't
write a test because I'm not sure the exact steps to reproduce. I'm not
sure a test is warranted for a simple bounds check anyway.

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8639395 [details]
MozReview Request: bzexport: guard against empty description (bug 1187939); r?smacleod

https://reviewboard.mozilla.org/r/14197/#review12801

Ship It!

Comment 3

[Gregory Szorc [:gps]]

url:        https://hg.mozilla.org/hgcustom/version-control-tools/rev/b21a891ca0076ced7aab75a0e43d1b927f369700
changeset:  b21a891ca0076ced7aab75a0e43d1b927f369700
user:       Gregory Szorc <[e-mail]>
date:       Mon Jul 27 14:10:49 2015 -0700
description:
bzexport: guard against empty description (bug 1187939); r=smacleod

Apparently the description can be empty for e.g. security bugs. I didn't
write a test because I'm not sure the exact steps to reproduce. I'm not
sure a test is warranted for a simple bounds check anyway.

Comment 4

[Gregory Szorc [:gps]]

Landed. Thanks for reporting.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

FWIW I encountered this when trying to do a bzexport -e with a hg patch with a description of 

Bug 1234567. r=somebody

Which I think should reproduce it easily / allow writing a testcase.