1187984 - Update about:privatebrowsing to include information about TP

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_pb_normal2.png

Current content in about:privatebrowsing is a bit dated. Given our work in Tracking Protection, we should update this to include more updated and relevant information.

Matej, could I get some help with this copy? The current design is attached. Essentially, we're looking to do something similar to desktop and talk a bit about both private browsing and tracking protection. This shows up every time a user creates a new private browsing tab.

Comment 1

[Matej Novak [:matej]]

Sure thing. Could attach the desktop copy here for reference?

Also, what's the timing?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Thanks so much! we're going to try to get this in for 42 I believe.

Comment 3

[Matej Novak [:matej]]

This one is hard to keep short and still get across all the pertinent info, but here's a stab at it:

Private Browsing + Tracking Protection

Firefox will prevent your browsing activity from being shared across websites and won't remember any history, but files you download and bookmarks you add will still be saved on your device.

Want to learn more?

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_mob_aboutpb.png

Here's the design! 

Matej, thought you might want to see what it looked like - thoughts?

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Martyn, can we update the copy? I'll attach the graphic.

Comment 6

[Matej Novak [:matej]]

It's pretty long. Could be tricky in l10n. How do you feel about it?

Another possibility would be to break it up under two headings and describe private browsing and tracking protection separately. Have we ever done anything like that before?

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Matej Novak [:matej] from comment #6)
> It's pretty long. Could be tricky in l10n. How do you feel about it?
> 
> Another possibility would be to break it up under two headings and describe
> private browsing and tracking protection separately. Have we ever done
> anything like that before?

Nope, we've not done that before. But I'm not sure that would solve the length issue either.

How do you feel about shortening the body or even using the original body and just making changes to the title and graphic?

Comment 8

[Matej Novak [:matej]]

I think it would be good to at least reference TP. Here's a shorter version:

Firefox will prevent you from being tracked and won't remember any history, but downloaded files and new bookmarks will still be saved on your device.

Better?

Comment 9

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_mob_aboutpb2.png

Yeah, works for me!

I'm thinking the learn more link still goes to the same article. Do we have a new one we might want Martyn to link to?

Comment 10

[Matej Novak [:matej]]

(In reply to Anthony Lam (:antlam) from comment #9)
> Created attachment 8640139 [details]
> prev_mob_aboutpb2.png
> 
> Yeah, works for me!

Ah yes, much better.

> I'm thinking the learn more link still goes to the same article. Do we have
> a new one we might want Martyn to link to?

No idea, unfortunately. Sorry.

Comment 11

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: icon_Masq_shield_SVG.svg

this might be a bit funky cause there's 3 colors but give this SVG a try Martyn. Same padding.

Comment 12

[Martyn Haigh (:mhaigh)]

APK to eyeball: https://dl.dropboxusercontent.com/u/7163922/Work/1187984.apk

Comment 13

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: icon_Masq_shield_SVG2.svg

I don't want to play with the height right now. so I'm removing the circle to keep the SVG's the same height.

Let's use this newer image.

Comment 14

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1187984 - Update about:privatebrowsing to include information about TP; r?liuche

Bug 1187984 - Update about:privatebrowsing to include information about TP; r?liuche

Comment 15

[Chenxia Liu [:liuche]]

Comment on attachment 8641165 [details]
MozReview Request: Bug 1187984 - Update about:privatebrowsing to include information about TP; r?liuche

https://reviewboard.mozilla.org/r/14439/#review13093

Ship It!

::: mobile/android/themes/core/images/privatebrowsing-mask-and-shield.svg:1
(Diff revision 1)
> +<svg width="400" height="138" viewBox="0 0 400 138" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><title>graphic 2</title><desc>Created with Sketch.</desc><defs><path d="M72.29 136.64C28.48 137.22 0.29 72.46 0.29 41.98L0.29 4.65C7.14 11.12 24.29 17.93 44.86 11.31 65.43 0.89 99.71-5.92 120.29 7.31 140.86-5.92 175.14 0.89 195.71 11.31 216.29 17.93 233.43 11.12 240.29 4.65L240.29 41.98C240.29 72.46 212.1 137.22 168.29 136.64 140.85 136.28 130.57 130.36 120.29 129.98 110 130.36 99.73 136.28 72.29 136.64ZM100.28 85.11C100.12 75.55 100.11 58.19 76.48 54.7 52.63 51.25 42.46 61.67 32.28 61.46 32.28 79.03 66.2 92.91 100.28 85.11ZM140.28 85.11C140.45 75.55 140.46 58.19 164.08 54.7 187.93 51.25 198.11 61.67 208.28 61.46 208.28 79.03 174.36 92.91 140.28 85.11Z" id="path-1"/></defs><g id="Page-1" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd"><g id="XXHDPI" transform="translate(-178.000000, -1050.000000)"><g id="graphic-2" transform="translate(178.000000, 1050.901172)"><path d="M399.38 24.32C399.36 19.92 396.45 16.4 392.71 15.32L349.86 8.32 307 15.32C303.26 16.4 300.35 19.92 300.33 24.32 300.31 34.22 300.37 52.28 301.29 60.32 303.17 83.36 307.43 94.81 317.48 108.32 330.16 126.08 349.86 128.32 349.86 128.32 349.86 128.32 369.56 126.08 382.24 108.32 392.28 94.81 396.54 83.36 398.43 60.32 399.34 52.28 399.4 34.22 399.38 24.32L399.38 24.32 399.38 24.32ZM390.81 59.32C388.95 82.65 384.72 92.07 376.52 103.32 367.16 116.27 353.36 119.66 349.86 120.32 346.31 119.65 332.54 116.26 323.19 103.32 314.99 92.07 310.76 82.65 308.9 59.32 308.17 53.88 307.91 40.97 307.95 24.32 307.96 23.78 308.17 23.56 308.9 23.32L349.86 16.32 390.81 23.32C391.54 23.56 391.75 23.78 391.76 24.32 391.8 40.96 391.54 53.87 390.81 59.32ZM326.05 98.32C318.68 87.15 315.78 78.92 314.62 59.32 313.99 54.06 313.66 45.26 313.67 30.32L348.9 23.32 348.9 113.32C344.72 112.4 334.23 108.99 326.05 98.32Z" id="XXHDPI" fill="#FFFFFF"/><g id="Path-Copy"><use fill="none" xlink:href="#path-1"/><use fill="none" xlink:href="#path-1"/><use fill="#5F6368" fill-rule="evenodd" xlink:href="#path-1"/></g></g></g></g></svg>

This needs a license, and also better formatting - indentations please!

Also, dropping some of the many-digit precision to 2 digits past the decimal point.

I don't really know if we have a canonical place for svg style, but I saw ally post this in a bug:
https://etherpad.mozilla.org/svg-guidelines

::: mobile/android/themes/core/jar.mn:122
(Diff revision 1)
> +  skin/images/privatebrowsing-mask-and-shield.svg           (images/privatebrowsing-mask-and-shield.svg)

This looks super indented, maybe match it to the way reader-style-icon-active-xxhdpi is, a few lines above?

::: mobile/android/chrome/content/aboutPrivateBrowsing.xhtml:28
(Diff revision 1)
> -    <img class="masq" src="chrome://browser/skin/images/privatebrowsing-mask.png" />
> +    <img class="showPrivate masq" src="chrome://browser/skin/images/privatebrowsing-mask-and-shield.svg" />

If we don't need this file anymore, remove it.

::: mobile/android/locales/en-US/chrome/aboutPrivateBrowsing.dtd:6
(Diff revision 1)
> +<!ENTITY privatebrowsingpage.title.private "Private Browsing<br />+ Tracking Protection">

Hm, so I don't see this anywhere in the strings - I assume a /n wouldn't work here? If you need to use the <br/>, I'd see if you could use something in the form of a format string - but again, we have these in Java, but I don't know if we can use them in the chrome code. You should also add a localization note about the "+" (as well as the format string if you end up using it, and if not, that <br/> is for formatting and shouldn't be localized).

Comment 16

[Martyn Haigh (:mhaigh)]

url:        https://hg.mozilla.org/integration/fx-team/rev/398a7477659e6723249f720db1d8fb9bf711f4a8
changeset:  398a7477659e6723249f720db1d8fb9bf711f4a8
user:       Martyn Haigh <[e-mail]>
date:       Fri Jul 31 14:04:46 2015 +0100
description:
Bug 1187984 - Update about:privatebrowsing to include information about TP; r=liuche

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/398a7477659e

Comment 18

[Francesco Lodolo [:flod]]

Thanks for the detailed localization note about the title, it helps.

I have another question though: is it OK to have "Firefox" hard-coded instead of using &brandShortName;? I know we do it sometimes, but I'm not sure if it was actually wanted here.

Comment 19

[Chenxia Liu [:liuche]]

Ah, that's my bad, I didn't catch that - Martyn, can you file a follow-up to use &brandShortName; instead of Firefox? Thank you for commenting on this, flod.

Comment 20

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot from 2015-08-14 16:08:55.png

Verified as fixed using:
Device: Alcatel One Touch (Android 4.1.2)
Builds: Firefox for Android 42.0a2 (2015-08-14) and  Firefox for Android 43.0a1 (2015-08-13)

Comment 21

[Teodora Vermesan (:TeoVermesan)]

Attachment: 505px-Screenshot_2015-09-22-12-45-08.png

Verified as fixed using:
Device: Samsung S6 Edge (Android 5.1)
Build: Firefox for Android 42 beta 1

about:privatebrowsing includes information about TP, but I will leave this bug RESOLVED FIXED, until Bug 1191333 - Replace hardcoded "Firefox" with short brand name variable, will be fixed on 42.