fold PSM's test_client_cert.js into necko's test_tls_server.js

RESOLVED FIXED in Firefox 42

Status

()

Core
Security: PSM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: keeler, Assigned: keeler)

Tracking

Trunk
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

See bug 1174288 and blockers. test_client_cert.js should generate its input certificate and key at build time. The tricky part here is that it wants a PKCS #12 file as input. That's not what we're testing, though, so we should be able to get away with generating a relatively simple PKCS #12 file that includes the certificate and key unencrypted.
Eh, better idea: fold PSM's test_client_cert.js into necko's test_tls_server.js since it already has a mechanism for coming up with a client certificate and doesn't involve an external binary (like ClientAuthServer, which we can now get rid of).
Summary: convert test_client_cert.js to generate its certificate and key at build time → fold PSM's test_client_cert.js into necko's test_tls_server.js
Created attachment 8641154 [details]
MozReview Request: bug 1188100 - fold PSM's test_client_cert.js into necko's test_tls_server.js r?mcmanus

bug 1188100 - fold PSM's test_client_cert.js into necko's test_tls_server.js r?mcmanus
Attachment #8641154 - Flags: review?(mcmanus)
https://reviewboard.mozilla.org/r/14433/#review13283

lgtm
Comment on attachment 8641154 [details]
MozReview Request: bug 1188100 - fold PSM's test_client_cert.js into necko's test_tls_server.js r?mcmanus

https://reviewboard.mozilla.org/r/14435/#review13279

Ship It!
Attachment #8641154 - Flags: review?(mcmanus) → review+
Thanks!
https://treeherder.mozilla.org/#/jobs?repo=try&revision=27ba7853340f
QA Contact: dkeeler

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/947359cbc153
Depends on: 1190674
https://hg.mozilla.org/mozilla-central/rev/947359cbc153
Assignee: nobody → dkeeler
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
QA Contact: dkeeler
You need to log in before you can comment on or make changes to this bug.