1188139 - Refactor Music to use modern L10n API

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Music is one of the first apps to receive NGA treatment. Let's make it use L10n API properly and consider transitioning it later to l20n.js.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1188139-refactor-music-l10n > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8639635 [details] [review]
[gaia] zbraniecki:1188139-refactor-music-l10n > mozilla-b2g:master

Jim, can you look at this? It passes treeherder and my manual tests :)

Comment 3

[Jim Porter (:squib)]

Now's probably not the best time to make API changes like this (unless it's blocking other development), since we're currently neck-deep in a wholesale rewrite of the Music app...

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to Jim Porter (:squib) from comment #3)
> Now's probably not the best time to make API changes like this (unless it's
> blocking other development), since we're currently neck-deep in a wholesale
> rewrite of the Music app...

We're aiming to migrate all apps to use NGA L10n API and we want to align this with the major refactoring that is going on toward NGA. Since Music is one of the apps targeting 2.5 with NGA we'd like to move it to l20n.js at the same time.

This patch is basically the only significant things that we need landed. We already landed such a refactor in SMS (bug 1171206) and we're about to land for Contacts/Callscreen. So I thought it may be actually easier for you to keep refactoring with the proper code already.

What do you think?

Comment 5

[Jim Porter (:squib)]

We're not refactoring the UI side so much as rewriting it from scratch (after we pull out as much non-UI code into the backend as possible). Since I'm not doing much with the UI side myself, I'll leave this up to Justin, who's working on a prototype of the new UI code (which will replace the music app fairly soon).

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Oh, cool! 

Justin, it would be awesome to help you get the L10n API right so that we can then swap l10n API without any major changes. The primary areas that we deprecate are:

 - mozL10n.get
 - LazyL10n
 - l10n_date.js use

If you can share the code you have I'll be happy to review and write patches to get the new UI in line with our work :)

Comment 7

[Justin D'Arcangelo [:justindarc]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #6)
> Oh, cool! 
> 
> Justin, it would be awesome to help you get the L10n API right so that we
> can then swap l10n API without any major changes. The primary areas that we
> deprecate are:
> 
>  - mozL10n.get
>  - LazyL10n
>  - l10n_date.js use
> 
> If you can share the code you have I'll be happy to review and write patches
> to get the new UI in line with our work :)

Sounds good, Zibi! I'll take a look at this patch to make sure I incorporate these changes. I'll ping you if I have any questions.

Comment 8

[Jim Porter (:squib)]

Comment on attachment 8639635 [details] [review]
[gaia] zbraniecki:1188139-refactor-music-l10n > mozilla-b2g:master

Clearing review for now, although if you'd like to land this before the new music app lands, let me know.

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

What's the timeline for the new music API? Are you targeting 2.5?

Comment 10

[Jim Porter (:squib)]

Yes. Hopefully an initial version will land in dev_apps this week.

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

Awesome, let's mark this as wontfix for now, and I'll help making the new UI work well with L10n API.