1188162 - Switch back to long month names on Lockscreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Théo Chevalier]

Follow-up of Bug 1172621, Lockscreen should be using long month names as it was the case when using l10n_date.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1188162-long-month-on-lockscreen > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8639638 [details] [review]
[gaia] zbraniecki:1188162-long-month-on-lockscreen > mozilla-b2g:master

Seems like a minor detail that I did wrong. Sorry for that.

Asking for review to make sure that module owners/peers are ok with long month on the lockscreen.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8639638 [details] [review]
[gaia] zbraniecki:1188162-long-month-on-lockscreen > mozilla-b2g:master

Looks good to me. The only concern is shall we set UX-review to verify it's OK for UX?

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Do you know who from the ux team to NI for that?

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Unfortunately I'm not sure who is responsible for this. But I think they will triage these bugs if I set the NI to FirefoxOS UX team.

Comment 6

[Tiffanie Shakespeare [:tif]]

Passing to Amy for comment. 

Thanks for pinging the UX team!

Comment 7

[Amy Lee [:amylee] UX]

(In reply to Tiffanie Shakespeare from comment #6)
> Passing to Amy for comment. 
> 
> Thanks for pinging the UX team!

Hi, 

I'm checking my dogfood Aries device and it looks like it currently does use the full month names. Can you send me a screenshot? I'm not sure what I should be looking for. Thanks!

Comment 8

[Théo Chevalier]

Attachment: Before Bug 1172621, long name in French

Comment 9

[Théo Chevalier]

Attachment: After Bug 1172621, short name in French

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: screenshot in en-US

Notice "Jul." instead of July

Comment 11

[Amy Lee [:amylee] UX]

Okay this looks good to me. Thanks!

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/0c47fe8d768048209a0c07ce638c7cd1b3e20039

Thanks all!