Closed
Bug 1188242
Opened 10 years ago
Closed 10 years ago
[B2G][ICC] Se correct RESPATH for IccService in B2G installer.
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
FxOS-S4 (07Aug)
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: bevis, Assigned: bevis)
Details
Attachments
(1 file)
|
1.26 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
In bug 1101331, the install path was divided into BINPATH and RESPATH,
https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/b2g/installer/package-manifest.in#l503
However, while introducing IccService in bug 1114935, we were not aware of the change that was done in bug 1101331.
https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/b2g/installer/package-manifest.in#l501
Hence, this bug is created to correct this.
Note: actually, there is no serious impact because BINPATH/RESPATH is only different in Mac OS X but we should still align the same configuration of other gonk services like MmsService, etc.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Hi Edgar,
May I have your review for this quick fix?
Thanks!
Attachment #8639726 -
Flags: review?(echen)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8639726 [details] [diff] [review]
Patch: Set Install Path of IccService to RESPATH.
Review of attachment 8639726 [details] [diff] [review]:
-----------------------------------------------------------------
Nice catch!!!!
Attachment #8639726 -
Flags: review?(echen) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
update tryserver result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d172e88b819a
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S4 (07Aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•