Closed Bug 1188242 Opened 9 years ago Closed 9 years ago

[B2G][ICC] Se correct RESPATH for IccService in B2G installer.

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S4 (07Aug)
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: bevis, Assigned: bevis)

Details

Attachments

(1 file)

Patch: Set Install Path of IccService to RESPATH.
1.26 KB, patch
edgar
: review+
Details | Diff | Splinter Review 
In bug 1101331, the install path was divided into BINPATH and RESPATH,
https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/b2g/installer/package-manifest.in#l503
However, while introducing IccService in bug 1114935, we were not aware of the change that was done in bug 1101331.
https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/b2g/installer/package-manifest.in#l501

Hence, this bug is created to correct this.

Note: actually, there is no serious impact because BINPATH/RESPATH is only different in Mac OS X but we should still align the same configuration of other gonk services like MmsService, etc.
Hi Edgar,

May I have your review for this quick fix?

Thanks!
Attachment #8639726 - Flags: review?(echen)
Comment on attachment 8639726 [details] [diff] [review]
Patch: Set Install Path of IccService to RESPATH.

Review of attachment 8639726 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!!!!
Attachment #8639726 - Flags: review?(echen) → review+
https://hg.mozilla.org/mozilla-central/rev/37b209a43f65
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S4 (07Aug)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: