1188280 - Provide a separate pref to disable autojoins by default

Status: RESOLVED WONTFIX

(Instantbird Graveyard :: Account manager, defect)

Description

[aleth [:aleth]]

Setting accountsManager.notification.userDisabled to false by default (as Tor messenger intends to do, see the linked url) leads to warning messages in the account manager that are confusing to the user ("You have disabled automatic connections"). There should be a separate pref for this use case. If it is true, the “Sign-in on startup” checkbox in accounts might be better off hidden too.

Comment 1

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #0)
> Setting accountsManager.notification.userDisabled

Sorry, pasted the string id instead. The pref is messenger.startup.action
https://dxr.mozilla.org/comm-central/source/chat/components/src/imAccounts.js#897

I assume that's what's being set at least? There's a command line flag that leads to the same result:
https://dxr.mozilla.org/comm-central/source/im/components/ibCommandLineHandler.js#20

Comment 2

[Florian Quèze [:florian]]

Instead of adding yet another pref, can we detect that the pref has no user-set value?

Comment 3

[aleth [:aleth]]

It would also be good to clarify what the intended behaviour is here. Do you wish to turn off automatic connection only at startup, or autojoins throughout?

Comment 4

[arlolra]

> I assume that's what's being set at least?

Yes, see https://gitweb.torproject.org/tor-messenger-build.git/tree/projects/instantbird/preferences.patch#n134


> It would also be good to clarify what the intended behaviour is here. Do you
> wish to turn off automatic connection only at startup, or autojoins
> throughout?

Throughout, as a safeguard against unintentional presence leaks.

Hiding the checkboxes is good idea for us as well. Does it make sense to add a pref for this use case? feel free to decline.

Comment 5

[arlolra]

In retrospect, a flag for something like this is probably all we'd want,


diff --git a/chat/components/src/imAccounts.js b/chat/components/src/imAccounts.js
index c13c6100d..5bfea57f2 100644
--- a/chat/components/src/imAccounts.js
+++ b/chat/components/src/imAccounts.js
@@ -588,7 +588,7 @@ imAccount.prototype = {
   },
 
   get autoLogin() {
-    let autoLogin = true;
+    let autoLogin = false;
     try {
       autoLogin = this.prefBranch.getBoolPref(kPrefAccountAutoLogin);
     } catch (e) { }
diff --git a/im/content/accountWizard.xul b/im/content/accountWizard.xul
index 5fa5b8293..f0933af7f 100644
--- a/im/content/accountWizard.xul
+++ b/im/content/accountWizard.xul
@@ -138,7 +138,7 @@
       <rows id="summaryRows"/>
     </grid>
     <separator/>
-    <checkbox id="connectAutomatically" label= "&accountSummary.connectAutomatically.label;" checked="true"/>
+    <checkbox id="connectAutomatically" label= "&accountSummary.connectAutomatically.label;" checked="false"/>
   </wizardpage>
 
 </wizard>

Comment 6

[Sylvestre Ledru [:Sylvestre]]

On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.