Send Tab should send immediately

RESOLVED FIXED

Status

()

Firefox for iOS
Sync
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: fluffyemily, Assigned: fluffyemily)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios+)

Details

(Whiteboard: noteworthy)

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
rnewman
: review+
rnewman
: feedback+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
Sending tabs should send the tab immediately and not wait until the next scheduled sync
(Assignee)

Comment 1

2 years ago
Created attachment 8639797 [details] [review]
Pull request

A change I swore I'd already made (sending commands as dict rather than string) wasn't there. Also ensured that a sync of clients is performed as soon as a tab is sent rather than waiting until the next scheduled sync occurs
Attachment #8639797 - Flags: review?(sleroux)
Comment on attachment 8639797 [details] [review]
Pull request

This is so cool. LGTM
Attachment #8639797 - Flags: review?(sleroux) → review+
tracking-fxios: ? → +
Comment on attachment 8639797 [details] [review]
Pull request

This isn't quite ready to go, so clearing the r+ for clarity.
Attachment #8639797 - Flags: review+ → feedback+
(Assignee)

Updated

2 years ago
Attachment #8639797 - Flags: review?(rnewman)
Comment on attachment 8639797 [details] [review]
Pull request

LGTM with one comment nit. Tidy it, test it, land it! Thanks for being patient.
Attachment #8639797 - Flags: review?(rnewman) → review+
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
https://github.com/mozilla/firefox-ios/commit/cb910aa250ed1213d0f7cc2299b4b1200d7329af
Whiteboard: noteworthy
You need to log in before you can comment on or make changes to this bug.