Closed Bug 1188299 Opened 9 years ago Closed 9 years ago

Send Tab should send immediately

Categories

(Firefox for iOS :: Sync, defect)

Other
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios + ---

People

(Reporter: fluffyemily, Assigned: fluffyemily)

Details

(Whiteboard: noteworthy)

Attachments

(1 file)

47 bytes, text/x-github-pull-request
rnewman
: review+
rnewman
: feedback+
Details | Review
Sending tabs should send the tab immediately and not wait until the next scheduled sync
Attached file Pull request
A change I swore I'd already made (sending commands as dict rather than string) wasn't there. Also ensured that a sync of clients is performed as soon as a tab is sent rather than waiting until the next scheduled sync occurs
Attachment #8639797 - Flags: review?(sleroux)
Comment on attachment 8639797 [details] [review] Pull request This is so cool. LGTM
Attachment #8639797 - Flags: review?(sleroux) → review+
Comment on attachment 8639797 [details] [review] Pull request This isn't quite ready to go, so clearing the r+ for clarity.
Attachment #8639797 - Flags: review+ → feedback+
Attachment #8639797 - Flags: review?(rnewman)
Comment on attachment 8639797 [details] [review] Pull request LGTM with one comment nit. Tidy it, test it, land it! Thanks for being patient.
Attachment #8639797 - Flags: review?(rnewman) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: