Closed Bug 1188382 Opened 7 years ago Closed 2 months ago

Drag/drop from the location bar / identity icon when in Reader mode doesn't provide the original URL

Categories

(Toolkit :: Reader Mode, defect, P3)

39 Branch
defect

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: designakt, Assigned: hagopi10)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reader-mode-firefox-integration])

Attachments

(2 files)

Using the "Email link to this page" button produces an email with a link to the reader view, which only works if the receiver of the email uses Firefox.
Should instead produce an email with the url of the original page.
Actually if I select the url and drag it somewhere/copy it to clipboard - then I get unwanted about:reader link, not the original one (which is displayed in urlbar!)
I was going to file a separate bug, but it makes sense to make the Summary of this bug more general
Michael, as I know you worked on this, could you please cc the right people on this bug.
Flags: needinfo?(mmaslaney)
Sorry, comment 1 is inaccurate: I get unwanted url only if I _drag_ selected url or Identity block
See Also: → 1243053
Marco, is there a generic solution for the dnd side of things in terms of things the location bar already does/checks?
Flags: needinfo?(mmaslaney) → needinfo?(mak77)
Priority: -- → P3
Summary: Sending per Mail from Reader View provides a Reader View URL (which only works in Firefox) → Sending per Mail from Reader View doesn't provide the original URL, nor does drag/drop from the location bar / identity icon
(In reply to :Gijs Kruitbosch from comment #4)
> Marco, is there a generic solution for the dnd side of things in terms of
> things the location bar already does/checks?

Nothing fancy, all the code is at
http://searchfox.org/mozilla-central/source/browser/base/content/urlbarBindings.xml#1008

We don't have a policy about "what we drag" that can answer your question whether we should drag about:reader or not, so we mus make one here.
Currently we just fill the dataTransfer with gBrowser.selectedBrowser.currentURI.
Flags: needinfo?(mak77)
another interesting question is "what do we want for copy"? Usually drag and copy do the same thing, so we may want to fix both.
Though, is it expected that I select a uri, and on copy I get a different one in my clipboard? On the other side, copy has also a workaround, I can unselect the about:reader part (annoying but feasible).
(In reply to Marco Bonardo [::mak] from comment #6)
> another interesting question is "what do we want for copy"? Usually drag and
> copy do the same thing, so we may want to fix both.
> Though, is it expected that I select a uri, and on copy I get a different
> one in my clipboard? On the other side, copy has also a workaround, I can
> unselect the about:reader part (annoying but feasible).

Copy already works. We have a copy-paste handler for the http:// prefix stuff and it has code: https://dxr.mozilla.org/mozilla-central/source/browser/base/content/urlbarBindings.xml#616-621
See Also: → 1185918
Whiteboard: [reader-mode-firefox-integration]

Sharing via mail was fixed in bug 1366327. That's probably what needs to happen to the identity block, too, probably here: https://searchfox.org/mozilla-central/rev/66086345467c69685434dd1c5177b30a7511b1a5/browser/base/content/browser-siteIdentity.js#925 .

Depends on: 1366327
Summary: Sending per Mail from Reader View doesn't provide the original URL, nor does drag/drop from the location bar / identity icon → Drag/drop from the location bar / identity icon when in Reader mode doesn't provide the original URL
Depends on: 1748655
Blocks: 1748655
No longer depends on: 1748655
Assignee: nobody → hagopi10
Status: NEW → ASSIGNED
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adbf8f2ecf80
fixed drag/drop link in reader mode. r=niklas,mtigley
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.