Status

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: david.weir, Assigned: david.weir)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

4 years ago
Hi I have done that language file using Atom if you need me to edit it please feel free to update the bug with the edit to it
(Assignee)

Updated

4 years ago
Locale: en-GB / English (British)
(Assignee)

Comment 1

4 years ago
Posted file download_button.lang (obsolete) —
Hi I have updated the slightly newer file as the last one had one minor edit I missed out
Attachment #8639959 - Attachment is obsolete: true
(Assignee)

Comment 2

4 years ago
Hi Ian I am wondering if you can look at my patch and review this if possible
Flags: needinfo?(iann_bugzilla)
I'd suggest to double check how Atom is configured, looks like it's changing all the line endings (but I'm also not familiar with Atom)
https://discuss.atom.io/t/newline-character-in-windows/13741
(Assignee)

Comment 4

4 years ago
Posted file download_button.lang (obsolete) —
this should now be fixed at last as I followed a fellow locale instructions on how to do the patch
Attachment #8639962 - Attachment is obsolete: true
(In reply to David Weir (satdav) from comment #4)
> Created attachment 8640096 [details]
> download_button.lang
> 
> this should now be fixed at last as I followed a fellow locale instructions
> on how to do the patch

Yep, this looks good now. Let's see if Ian replies, I'm especially interested in long term plans for en-GB and mozilla.org

Comment 6

4 years ago
Parsing the file for correct use of English - it all seems fine to me. I would query however the incorrect use of capital letters as in "Free Download", "Supported Devices", and "What’s New" - the second word in each case should begin with a lowercase letter.
Hope this helps.
Spike

Comment 7

4 years ago
Posted patch dbl.diffSplinter Review
I've created a diff as it is easier to see what has changed for review purposes.
The style for capitalisation is correct. I would usually only expect spelling corrections nothing for capitalisation.
Flags: needinfo?(iann_bugzilla)
Attachment #8641716 - Flags: review+

Comment 8

4 years ago
File without the last two empty lines trimmed.
Attachment #8640096 - Attachment is obsolete: true
Committed in r144075.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Assignee: nobody → david.weir
(Assignee)

Updated

4 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.