1188470 - Download button for En-Gb Site

Status: VERIFIED FIXED

(www.mozilla.org :: L10N, defect)

Description

[David Weir (satdav)]

Attachment: the download button Lang file for en-gb

Hi I have done that language file using Atom if you need me to edit it please feel free to update the bug with the edit to it

Comment 1

[David Weir (satdav)]

Attachment: download_button.lang

Hi I have updated the slightly newer file as the last one had one minor edit I missed out

Comment 2

[David Weir (satdav)]

Hi Ian I am wondering if you can look at my patch and review this if possible

Comment 3

[Francesco Lodolo [:flod]]

I'd suggest to double check how Atom is configured, looks like it's changing all the line endings (but I'm also not familiar with Atom)
https://discuss.atom.io/t/newline-character-in-windows/13741

Comment 4

[David Weir (satdav)]

Attachment: download_button.lang

this should now be fixed at last as I followed a fellow locale instructions on how to do the patch

Comment 5

[Francesco Lodolo [:flod]]

(In reply to David Weir (satdav) from comment #4)
> Created attachment 8640096 [details]
> download_button.lang
> 
> this should now be fixed at last as I followed a fellow locale instructions
> on how to do the patch

Yep, this looks good now. Let's see if Ian replies, I'm especially interested in long term plans for en-GB and mozilla.org

Comment 6

[spikeuk1]

Parsing the file for correct use of English - it all seems fine to me. I would query however the incorrect use of capital letters as in "Free Download", "Supported Devices", and "What’s New" - the second word in each case should begin with a lowercase letter.
Hope this helps.
Spike

Comment 7

[Ian Neal]

Attachment: dbl.diff

I've created a diff as it is easier to see what has changed for review purposes.
The style for capitalisation is correct. I would usually only expect spelling corrections nothing for capitalisation.

Comment 8

[Ian Neal]

Attachment: download_button.lang

File without the last two empty lines trimmed.

Comment 9

[Francesco Lodolo [:flod]]

Committed in r144075.