1188539 - Remove the deprecated TouchList::identifiedTouch method

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Matt Brubeck (:mbrubeck)]

The identifiedTouch method appeared in earlier drafts of the Touch Events v2 specification, but has now been removed from the spec.  It was never implemented by any other browsers:

https://github.com/w3c/touch-events/issues/20

We should remove this interface and its implementation:

https://dxr.mozilla.org/mozilla-central/search?q=identifiedTouch

Comment 1

[Aaron Raimist [:aaronraimist]]

Attachment: MozReview Request: Bug 1188539 - Remove the deprecated TouchList::identifiedTouch method; r?mbrubeck

Bug 1188539 - Remove the deprecated TouchList::identifiedTouch method; r?mbrubeck

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8647285 [details]
MozReview Request: Bug 1188539 - Remove the deprecated TouchList::identifiedTouch method; r?mbrubeck

Look good!  I'm not officially a reviewer for this code, so I'm requesting a second review from jst.

Comment 3

[Aaron Raimist [:aaronraimist]]

The try push failed the first time on the mochitest browser chrome tests.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cd67d69ee89

Ran those tests a second time and now they are green. I don't think this is an issue with my code. This test is being skipped on mozilla-central, see bug 1119906.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cd67d69ee89

Comment 4

[Aaron Raimist [:aaronraimist]]

(In reply to Aaron Raimist [:aaronraimist] from comment #3)
> The try push failed the first time on the mochitest browser chrome tests.
> 
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cd67d69ee89
> 
> Ran those tests a second time and now they are green. I don't think this is
> an issue with my code. This test is being skipped on mozilla-central, see
> bug 1119906.
> 
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cd67d69ee89

Sorry the second link should have been:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6175cd283bda

but I just realized that this isn't actually running my code, and only ran the try patch (https://hg.mozilla.org/try/rev/6175cd283bda). This might be a bug in Review Board.

Comment 5

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/touchlist-identifiedtouch-will-be-removed/

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab752670d22aae2f4f56cd042a98ec239e0dc931
Bug 1188539 - Remove the deprecated TouchList::identifiedTouch method; r=jst

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab752670d22a

Comment 8

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/touchlist-identifiedtouch-has-been-removed/

Comment 9

[Eric Shepherd [:sheppy]]

Someone had already marked this deprecated; I've changed it to obsolete now that it's actually been removed. I also added this function back to the main list on the main TouchList page, since it shouldn't have been removed. It's now correctly there but labeled as obsolete.