Closed Bug 1188539 Opened 5 years ago Closed 4 years ago

Remove the deprecated TouchList::identifiedTouch method

Categories

(Core :: DOM: Events, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox42 --- affected
firefox49 --- fixed

People

(Reporter: mbrubeck, Assigned: aaronraimist, Mentored)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

The identifiedTouch method appeared in earlier drafts of the Touch Events v2 specification, but has now been removed from the spec.  It was never implemented by any other browsers:

https://github.com/w3c/touch-events/issues/20

We should remove this interface and its implementation:

https://dxr.mozilla.org/mozilla-central/search?q=identifiedTouch
Bug 1188539 - Remove the deprecated TouchList::identifiedTouch method; r?mbrubeck
Attachment #8647285 - Flags: review?(mbrubeck)
Assignee: nobody → aaronraimist
Status: NEW → ASSIGNED
Comment on attachment 8647285 [details]
MozReview Request: Bug 1188539 - Remove the deprecated TouchList::identifiedTouch method; r?mbrubeck

Look good!  I'm not officially a reviewer for this code, so I'm requesting a second review from jst.
Attachment #8647285 - Flags: review?(mbrubeck)
Attachment #8647285 - Flags: review?(jst)
Attachment #8647285 - Flags: feedback+
Attachment #8647285 - Flags: review?(jst) → review+
The try push failed the first time on the mochitest browser chrome tests.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cd67d69ee89

Ran those tests a second time and now they are green. I don't think this is an issue with my code. This test is being skipped on mozilla-central, see bug 1119906.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cd67d69ee89
Keywords: checkin-needed
(In reply to Aaron Raimist [:aaronraimist] from comment #3)
> The try push failed the first time on the mochitest browser chrome tests.
> 
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cd67d69ee89
> 
> Ran those tests a second time and now they are green. I don't think this is
> an issue with my code. This test is being skipped on mozilla-central, see
> bug 1119906.
> 
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cd67d69ee89

Sorry the second link should have been:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6175cd283bda

but I just realized that this isn't actually running my code, and only ran the try patch (https://hg.mozilla.org/try/rev/6175cd283bda). This might be a bug in Review Board.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ab752670d22a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Target Milestone: mozilla48 → mozilla49
Someone had already marked this deprecated; I've changed it to obsolete now that it's actually been removed. I also added this function back to the main list on the main TouchList page, since it shouldn't have been removed. It's now correctly there but labeled as obsolete.
You need to log in before you can comment on or make changes to this bug.