1188612 - Transferable errors should become NS_DOM_DATA_CLONE_ERR, not built-in spidermonkey errors.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

webmessaging/postMessage_dup_transfer_objects.htm tests that doing postMessage("blah", [foo, foo]); throws an NS_ERROR_DOM_DATA_CLONE_ERR.  Today it throws a builtin spidermonkey error.  There are a few parts to this:

1. We need to change the js engine to always call the error hook (in other words we need to ReportErrorTransferable for JSMSG_SC_DUP_TRANSFERABLE).
2. We need to change PostMessageEvent (and other structured clone callers) to actually use the error hook.
3. We need to test that the other ways that transferables can fail also get an NS_ERROR_DOM_DATA_CLONE_ERR.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I think baku is fixing 2 and 3 in one of his "make structured clone handling sane" bugs.

Comment 2

[Andrea Marchesini [:baku]]

I take this bug.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: clone6.patch

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b7e7fe8d581

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3b7e7fe8d581