Closed
Bug 1188626
Opened 10 years ago
Closed 10 years ago
localhost URLs should not be recorded in history or included in top sites
Categories
(Firefox for iOS :: Data Storage, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: rnewman, Assigned: rnewman)
References
(Blocks 1 open bug)
Details
(Keywords: crash)
Attachments
(1 file)
This is causing Bug 1188623.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8640167 -
Flags: review?(sleroux)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8640167 [details] [review]
Pull req.
Looks good! I gotta split up commits more like you do - this was very easy to read.
Attachment #8640167 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks for the quick review!
https://github.com/mozilla/firefox-ios/commit/59557a69debaac99c362e49db78ba8c3c37c56b0
|
|
Assignee | |
Comment 4•10 years ago
|
||
This breaks ClearPrivateDataTests, which relies on being able to visit localhost URLs in order to populate history. I'll fix the test.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 5•10 years ago
|
||
This fixes that test. bnicholson cleared this approach on IRC, so landed without review.
https://github.com/mozilla/firefox-ios/commit/a22a3b8b3073a931358aeb70d40d9813548bc544
|
|
Assignee | |
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•