Closed Bug 1188648 Opened 6 years ago Closed 6 years ago

[gaia-automation] Use --host-log always for marionette js tests

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox42 fixed)

RESOLVED FIXED
Tracking Status
firefox42 --- fixed

People

(Reporter: aus, Assigned: aus)

References

Details

Attachments

(1 file, 1 obsolete file)

We should permanently log gecko output for Gij to make things easier for developers to track down what's going on when they break tests or are adding/debugging new tests.
looking good. also, updated the pull request to use 'gecko_output.log' as the filename instead of 'gecko-output.log' so that it's consistent with the other multi-word filenames we use.
Comment on attachment 8640201 [details] [review]
[gaia] nullaus:bug1188648 > mozilla-b2g:master

nice nice
Attachment #8640201 - Flags: review+
Commit (master): https://github.com/mozilla-b2g/gaia/commit/494d8169d36ee497d3e2111c839382dde5ebaeba

Enjoy those gecko_output logs peoples!
Next up is a small patch to mozharness to do the same thing for gecko builds that run Gij.
Attachment #8640223 - Flags: review?(jgriffin)
Comment on attachment 8640223 [details] [diff] [review]
Patch - Always log gecko output when running Gij

Review of attachment 8640223 [details] [diff] [review]:
-----------------------------------------------------------------

Or better:

env['HOST_LOG'] = os.path.join(dirs['abs_log_dir'], 'gecko_output.log')
Attachment #8640223 - Flags: review?(jgriffin) → review+
Attachment #8640223 - Attachment is obsolete: true
(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> Comment on attachment 8640223 [details] [diff] [review]
> Patch - Always log gecko output when running Gij
> 
> Review of attachment 8640223 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Or better:
> 
> env['HOST_LOG'] = os.path.join(dirs['abs_log_dir'], 'gecko_output.log')

Hmm, so I guess it worked, but then it didn't copy the log into the upload/logs folder which in turn meant I had a log file, but it didn't get pushed to S3 as part of the other logs. How do I update the config for it to copy that log as well?
Flags: needinfo?(jgriffin)
I don't know how TaskCluster handles this; you should ask garndt.
Flags: needinfo?(jgriffin) → needinfo?(garndt)
I'm going to clear out the ni? because it looks like this is working.  Checked a gij job on treeherder [1]
and noticed the link for a valid gecko_output.log artifact [2].  Sorry for the late response, but it looks like the right things are setup.


[1] https://tools.taskcluster.net/task-inspector/#VTSAEwJuSXaa2k_3d0Y6eA/0
[2] https://queue.taskcluster.net/v1/task/VTSAEwJuSXaa2k_3d0Y6eA/runs/0/artifacts/public/marionette_js_tests/gecko_output.log
Flags: needinfo?(garndt)
Depends on: 1240557
I can't access the task from comment 15 anymore (I can access the runs, but not the task summary). I would be curious to know which repo this task was run from :)
You need to log in before you can comment on or make changes to this bug.