1188648 - [gaia-automation] Use --host-log always for marionette js tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Aus Lacroix [:aus]]

We should permanently log gecko output for Gij to make things easier for developers to track down what's going on when they break tests or are adding/debugging new tests.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] nullaus:bug1188648 > mozilla-b2g:master

Comment 2

[Aus Lacroix [:aus]]

looking good. also, updated the pull request to use 'gecko_output.log' as the filename instead of 'gecko-output.log' so that it's consistent with the other multi-word filenames we use.

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8640201 [details] [review]
[gaia] nullaus:bug1188648 > mozilla-b2g:master

nice nice

Comment 4

[Aus Lacroix [:aus]]

Commit (master): https://github.com/mozilla-b2g/gaia/commit/494d8169d36ee497d3e2111c839382dde5ebaeba

Enjoy those gecko_output logs peoples!

Comment 5

[Aus Lacroix [:aus]]

Next up is a small patch to mozharness to do the same thing for gecko builds that run Gij.

Comment 6

[Aus Lacroix [:aus]]

Attachment: Patch - Always log gecko output when running Gij

Comment 7

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8640223 [details] [diff] [review]
Patch - Always log gecko output when running Gij

Review of attachment 8640223 [details] [diff] [review]:
-----------------------------------------------------------------

Or better:

env['HOST_LOG'] = os.path.join(dirs['abs_log_dir'], 'gecko_output.log')

Comment 8

[Aus Lacroix [:aus]]

(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> Comment on attachment 8640223 [details] [diff] [review]
> Patch - Always log gecko output when running Gij
> 
> Review of attachment 8640223 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Or better:
> 
> env['HOST_LOG'] = os.path.join(dirs['abs_log_dir'], 'gecko_output.log')

Hmm, so I guess it worked, but then it didn't copy the log into the upload/logs folder which in turn meant I had a log file, but it didn't get pushed to S3 as part of the other logs. How do I update the config for it to copy that log as well?

Comment 9

[Jonathan Griffin (:jgriffin)]

I don't know how TaskCluster handles this; you should ask garndt.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/48c08708614a

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/660ee90a859e

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/48c08708614a
https://hg.mozilla.org/mozilla-central/rev/660ee90a859e

Comment 13

[Chris Cooper [:coop] (he/him)]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/80df8b8b2376

Comment 14

[Chris Cooper [:coop] (he/him)]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/80df8b8b2376

Comment 15

[Greg Arndt [:garndt]]

I'm going to clear out the ni? because it looks like this is working.  Checked a gij job on treeherder [1]
and noticed the link for a valid gecko_output.log artifact [2].  Sorry for the late response, but it looks like the right things are setup.


[1] https://tools.taskcluster.net/task-inspector/#VTSAEwJuSXaa2k_3d0Y6eA/0
[2] https://queue.taskcluster.net/v1/task/VTSAEwJuSXaa2k_3d0Y6eA/runs/0/artifacts/public/marionette_js_tests/gecko_output.log

Comment 16

[Julien Wajsberg [:julienw]]

I can't access the task from comment 15 anymore (I can access the runs, but not the task summary). I would be curious to know which repo this task was run from :)