1188732 - Downloads in Private Window are canceled if about:downloads is open and you close the last tab if new tab is set to blank page or an extension page

Status: RESOLVED WORKSFORME

(Firefox :: Private Browsing, defect)

Description

[Théo Chevalier]

STR:

1. Open a new Private Window
2. Download a file. From http://www.ubuntu.com/download/desktop/thank-you/?version=14.04.2&architecture=amd64 for instance or a new Firefox build.
3. Click on Download manager icon in toolbar
4. Click on "Display all downloads"
5. about:downloads opens in a new tab (and you can see your download)
6. Close the other tab (The one from which you started the download).


Actual results:

Your download is canceled and disappears from the download manager.

Expected results:

Your download is still ongoing.

Tested on Ubuntu 15.04.

Can reproduce the issue on latest Nightly (42).
Can't reproduce on Dev Edition from 2015-07-28

[Tracking Requested - why for this release]:
Quite a bad regression, download is lost, user is not warned.

Comment 1

[Marco Bonardo [:mak]]

Thank you, it would be nice to figure a regression-window for this using mozregression

Comment 2

[Théo Chevalier]

Last good build: -> When a download starts from a Private Window, it's handled by the download manager in the *regular* window 

build_date: 2014-11-10
build_path: /tmp/tmp1Vb_uY/2014-11-10--mozilla-central--firefox-36.0a1.en-US.linux-x86_64.tar.bz2
build_txt_url: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/11/2014-11-10-03-02-04-mozilla-central/firefox-36.0a1.en-US.linux-x86_64.txt
build_type: nightly
build_url: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/11/2014-11-10-03-02-04-mozilla-central/firefox-36.0a1.en-US.linux-x86_64.tar.bz2
changeset: d380166816dd
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d380166816dd&tochange=cbe6afcae26c
repo: mozilla-central
repository: https://hg.mozilla.org/mozilla-central





First bad build: -> When a download starts from a Private Window, it's handled by the download manager in the *private* window 

build_date: 2014-11-11
build_path: /tmp/tmp1Vb_uY/2014-11-11--mozilla-central--firefox-36.0a1.en-US.linux-x86_64.tar.bz2
build_txt_url: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/11/2014-11-11-03-02-03-mozilla-central/firefox-36.0a1.en-US.linux-x86_64.txt
build_type: nightly
build_url: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/11/2014-11-11-03-02-03-mozilla-central/firefox-36.0a1.en-US.linux-x86_64.tar.bz2
changeset: cbe6afcae26c
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=eb0d3b3c0b22&tochange=7f0d92595432
repo: mozilla-central
repository: https://hg.mozilla.org/mozilla-central

Comment 3

[Théo Chevalier]

Actually in 2014-11-10 build, if you close the private tab from which you started the download, it stops the download in the regular window as well. Looking for another regression-window.

Comment 4

[Théo Chevalier]

Ok, ignore comment #2. New window:

Last good: 2014-09-10

build_path: /tmp/tmpr7Xbr7/2014-09-10--mozilla-central--firefox-35.0a1.en-US.linux-x86_64.tar.bz2
build_txt_url: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/09/2014-09-10-03-02-04-mozilla-central/firefox-35.0a1.en-US.linux-x86_64.txt
build_type: nightly
build_url: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/09/2014-09-10-03-02-04-mozilla-central/firefox-35.0a1.en-US.linux-x86_64.tar.bz2
changeset: 152ef25e89ae
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=06e1ca1fbf24&tochange=2db5b64f6d49
repo: mozilla-central
repository: https://hg.mozilla.org/mozilla-central



First bad: 2014-09-11

build_path: /tmp/tmpr7Xbr7/2014-09-11--mozilla-central--firefox-35.0a1.en-US.linux-x86_64.tar.bz2
build_txt_url: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/09/2014-09-11-06-41-10-mozilla-central/firefox-35.0a1.en-US.linux-x86_64.txt
build_type: nightly
build_url: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/09/2014-09-11-06-41-10-mozilla-central/firefox-35.0a1.en-US.linux-x86_64.tar.bz2
changeset: 98ea98c8191a
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=152ef25e89ae&tochange=98ea98c8191a
repo: mozilla-central
repository: https://hg.mozilla.org/mozilla-central

Comment 5

[Kate Glazko]

Tracking in 42 because regression and very annoying behavior for the user. Adding status flag affected to 42, see STR.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Looks like we are going to release 42 with this bug.

Comment 7

[Marat Tanalin]

The bug seems to take place ONLY if new-tab page is overridden by an extension (with the "chrome_url_overrides" -> "newtab" manifest property).

I encountered the issue with my own local (unpublished) extension, but the bug also reproduces with e.g. New Tab Tools.

Tested with the latest Nightly (61.0a1 20180328220110) and Developer Edition (60.0b7 20180326164103) and New Tab Tools 86.5.

The bug is INCREDIBLY annoying.

Comment 8

[Kestrel]

It also happens with the new tab page set to blank page (browser.newtabpage.enabled = false).

Comment 9

[achtbeiner]

Easy to reproduce:

1. In settings make sure "New tabs" is set to "Blank Page"
2. Start a download that takes a while to finish
3. Click on the downloads icon and then on "Display all downloads"
4. Close all tabs except the one that shows the download progress bar
=> Downloads will be cancelled and lost

Note: Even browser.tabs.closeWindowWithLastTab=false does NOT prevent this!

Comment 10

[Pascal Chevrel:pascalc]

3 year old regression, wontfix for 63.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late to fix in 64. Marking this issue as fix-optional for 65; if you land a patch in nightly and think it's low-risk for beta, please request uplift.

Comment 12

[Marat Tanalin]

Did not encounter the issue for a while, but now with Firefox 80 (Developer Edition 80.0b5), the issue seems to return. So there is probably a regression compared with Firefox 79 and older where the issue was apparently already fixed.

You start a download in a private window, you close the last tab, an empty tab is automatically opened instead, downloads are cancelled and disappearing as if there were no downloads running at all. No even a need for about:downloads to be opened for the issue to appear.

Comment 13

[tejassateesh]

This one is very easily reproducible and started happening with Firefox 80. Even if about:downloads tab is open, if you close all the other tabs in Private Mode when downloading files that were triggered on these Private Tabs, then the downloads are cancelled without a warning.

Comment 15

[:Gijs (he/him)]

I can reproduce this. It appears the problem is that a last-pb-context-exited notification is sent by docshell or ContentChild, because the about:downloads page is loaded with system principal and doesn't have private browsing state, so it is not counted.

Johann (feel free to forward), is there a straightforward way of fixing this? Feels like we should just be tracking user-visible private windows in the parent process (though I guess that's messy for Fenix?

Comment 16

[Marat Tanalin]

Looks like switching to the new user interface in Firefox 89+ fixed the issue.

Comment 17

[Kestrel]

Can confirm this was fixed in 91.

Fix window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=380804a8d81c48a7bfc67150207acf76cf35dd5e&tochange=55f827545de27e7c0545046a40fd95fea6254b69

Fixed by Bug 1701303.