1188735 - [graphene] browser.html branding

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Paul Rouget [:paul]]

We need a proper icon and the "browser.html" name (not graphene or B2G).

Comment 1

[Paul Rouget [:paul]]

Attachment: v1

Fabrice, it's not clear to me yet how we want to handle branding. Ideally, icon and name would come from the app itself, then we could ship an unbranded graphene.

For now, let's just build graphene with the browserhtml branding.

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8640304 [details] [diff] [review]
v1

Review of attachment 8640304 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed.

And I agree that we need to find a solution to let the "system" app provide the branding.

::: b2g/branding/browserhtml/locales/en-US/brand.dtd
@@ +4,5 @@
> +
> +<!ENTITY  brandShortName  "Browser.html">
> +<!ENTITY  brandFullName   "Mozilla Browser.html">
> +<!ENTITY  vendorShortName "Mozilla">
> +<!ENTITY  logoTrademark   "Mozilla and the Mozilla logos are trademarks of the Mozilla Foundation.">

logoTrademark doesn't seem to be used anywhere in toolkit 9http://mxr.mozilla.org/mozilla-central/search?string=logoTrademark)

::: b2g/branding/browserhtml/locales/jar.mn
@@ +7,5 @@
> +@AB_CD@.jar:
> +% locale branding @AB_CD@ %locale/branding/
> +# Branding only exists in en-US
> +  locale/branding/brand.dtd        (en-US/brand.dtd)
> +* locale/branding/brand.properties (en-US/brand.properties)

why do you need that file to be pre-processed?

Comment 3

[Paul Rouget [:paul]]

Attachment: v1.1 (r=fabrice)

Comments addressed.

Comment 4

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/larch/rev/a992f02fc3ae

Comment 5

[Kevin Grandon :kgrandon]

Landed in mozilla-central via bug 1204965.