Closed Bug 1188735 Opened 4 years ago Closed 4 years ago

[graphene] browser.html branding

Categories

(Firefox OS Graveyard :: Runtime, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: paul, Assigned: paul)

References

Details

(Whiteboard: graphene-larch)

Attachments

(1 file, 1 obsolete file)

We need a proper icon and the "browser.html" name (not graphene or B2G).
Attached patch v1 (obsolete) — Splinter Review
Fabrice, it's not clear to me yet how we want to handle branding. Ideally, icon and name would come from the app itself, then we could ship an unbranded graphene.

For now, let's just build graphene with the browserhtml branding.
Attachment #8640304 - Flags: review?(fabrice)
Comment on attachment 8640304 [details] [diff] [review]
v1

Review of attachment 8640304 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed.

And I agree that we need to find a solution to let the "system" app provide the branding.

::: b2g/branding/browserhtml/locales/en-US/brand.dtd
@@ +4,5 @@
> +
> +<!ENTITY  brandShortName  "Browser.html">
> +<!ENTITY  brandFullName   "Mozilla Browser.html">
> +<!ENTITY  vendorShortName "Mozilla">
> +<!ENTITY  logoTrademark   "Mozilla and the Mozilla logos are trademarks of the Mozilla Foundation.">

logoTrademark doesn't seem to be used anywhere in toolkit 9http://mxr.mozilla.org/mozilla-central/search?string=logoTrademark)

::: b2g/branding/browserhtml/locales/jar.mn
@@ +7,5 @@
> +@AB_CD@.jar:
> +% locale branding @AB_CD@ %locale/branding/
> +# Branding only exists in en-US
> +  locale/branding/brand.dtd        (en-US/brand.dtd)
> +* locale/branding/brand.properties (en-US/brand.properties)

why do you need that file to be pre-processed?
Attachment #8640304 - Flags: review?(fabrice) → review+
Attached patch v1.1 (r=fabrice)Splinter Review
Comments addressed.
Assignee: nobody → paul
Attachment #8640304 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8640937 - Flags: review+
Landed in mozilla-central via bug 1204965.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.