loadedmetadata not fired when single appendBuffer contains multiple init segments

RESOLVED FIXED in Firefox 42

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks: 1 bug)

Trunk
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
If a single appendBuffer is made and contains multiple init segments ; then loadedmetadata isn't fired.
(Assignee)

Comment 1

3 years ago
Created attachment 8640416 [details] [diff] [review]
[MSE] P1. Fix Is*SegmentPresent.

The name IsInitSegmentPresent and IsMediaSegmentPresent was misleading. As they are to return true only if data *starts* with such segment and not just contain.

Carrying r+ from bug 1188341
Attachment #8640416 - Flags: review+
(Assignee)

Comment 2

3 years ago
Created attachment 8640417 [details] [diff] [review]
[MSE] P2. Disambiguate naming of mActiveTrack boolean.

We considered that mActiveTrack was a global variable, however it is reset each time a new init segment is received.
Should two init segments be received in the same appendBuffer it would have been set to false, causing metadata to never be parsed.

Carrying r+ from bug 1188341
Attachment #8640417 - Flags: review+
(Assignee)

Updated

3 years ago
Assignee: nobody → jyavenard
https://hg.mozilla.org/mozilla-central/rev/af0fcf52e4b7
https://hg.mozilla.org/mozilla-central/rev/ce9a1842eae2
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.