1188804 - loadedmetadata not fired when single appendBuffer contains multiple init segments

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

If a single appendBuffer is made and contains multiple init segments ; then loadedmetadata isn't fired.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: [MSE] P1. Fix Is*SegmentPresent.

The name IsInitSegmentPresent and IsMediaSegmentPresent was misleading. As they are to return true only if data *starts* with such segment and not just contain.

Carrying r+ from bug 1188341

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: [MSE] P2. Disambiguate naming of mActiveTrack boolean.

We considered that mActiveTrack was a global variable, however it is reset each time a new init segment is received.
Should two init segments be received in the same appendBuffer it would have been set to false, causing metadata to never be parsed.

Carrying r+ from bug 1188341

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af0fcf52e4b7
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce9a1842eae2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af0fcf52e4b7
https://hg.mozilla.org/mozilla-central/rev/ce9a1842eae2