The default bug view has changed. See this FAQ.

Compacting GC happens too often

RESOLVED FIXED in Firefox 41

Status

()

Core
JavaScript: GC
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox40 wontfix, firefox41 fixed, firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Currently we run trigger a compacting GC when the user had been inactive for 20 seconds.  This results in a lot of compacting GCs and probably is causing some of the reports of long GC pauses occurring.

We should make this happen only after the user has been inactive for 5 minutes (except on nightly, to improve test coverage).

We should also make this a pref so it can be changed easily.
(Assignee)

Comment 1

2 years ago
Created attachment 8640549 [details] [diff] [review]
less-frequent-compaction
Attachment #8640549 - Flags: review?(bugs)
Comment on attachment 8640549 [details] [diff] [review]
less-frequent-compaction

Should we land this also on branches?
Attachment #8640549 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

2 years ago
(In reply to Olli Pettay [:smaug] from comment #2)
> Should we land this also on branches?

Yes, that's the plan.

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/60b5a53aeb8f
https://hg.mozilla.org/mozilla-central/rev/60b5a53aeb8f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
(Assignee)

Updated

2 years ago
Blocks: 1130439
No longer blocks: 1122579
(Assignee)

Comment 6

2 years ago
Comment on attachment 8640549 [details] [diff] [review]
less-frequent-compaction

Approval Request Comment
[Feature/regressing bug #]: Bug 1130439
[User impact if declined]: Possible long GC pauses.
[Describe test coverage new/current, TreeHerder]: On central for 4 days.
[Risks and why]: Low.
[String/UUID change made/needed]: None.
Attachment #8640549 - Flags: approval-mozilla-beta?
Attachment #8640549 - Flags: approval-mozilla-aurora?
status-firefox40: --- → wontfix
status-firefox41: --- → affected
Comment on attachment 8640549 [details] [diff] [review]
less-frequent-compaction

The next beta of 40 will be the RC. So, this is too late to change anything wrt the gc. This will have to ride the train from 41.
Attachment #8640549 - Flags: approval-mozilla-beta?
Attachment #8640549 - Flags: approval-mozilla-beta-
Attachment #8640549 - Flags: approval-mozilla-aurora?
Attachment #8640549 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/47c89dde72d9
status-firefox41: affected → fixed
You need to log in before you can comment on or make changes to this bug.