Closed Bug 1188834 Opened 5 years ago Closed 5 years ago

Compacting GC happens too often

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox40 --- wontfix
firefox41 --- fixed
firefox42 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

Currently we run trigger a compacting GC when the user had been inactive for 20 seconds.  This results in a lot of compacting GCs and probably is causing some of the reports of long GC pauses occurring.

We should make this happen only after the user has been inactive for 5 minutes (except on nightly, to improve test coverage).

We should also make this a pref so it can be changed easily.
Attachment #8640549 - Flags: review?(bugs)
Comment on attachment 8640549 [details] [diff] [review]
less-frequent-compaction

Should we land this also on branches?
Attachment #8640549 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #2)
> Should we land this also on branches?

Yes, that's the plan.
https://hg.mozilla.org/mozilla-central/rev/60b5a53aeb8f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Blocks: 1130439
No longer blocks: CompactingGC
Comment on attachment 8640549 [details] [diff] [review]
less-frequent-compaction

Approval Request Comment
[Feature/regressing bug #]: Bug 1130439
[User impact if declined]: Possible long GC pauses.
[Describe test coverage new/current, TreeHerder]: On central for 4 days.
[Risks and why]: Low.
[String/UUID change made/needed]: None.
Attachment #8640549 - Flags: approval-mozilla-beta?
Attachment #8640549 - Flags: approval-mozilla-aurora?
Comment on attachment 8640549 [details] [diff] [review]
less-frequent-compaction

The next beta of 40 will be the RC. So, this is too late to change anything wrt the gc. This will have to ride the train from 41.
Attachment #8640549 - Flags: approval-mozilla-beta?
Attachment #8640549 - Flags: approval-mozilla-beta-
Attachment #8640549 - Flags: approval-mozilla-aurora?
Attachment #8640549 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.