Closed Bug 1188899 Opened 9 years ago Closed 9 years ago

[Contacts][NGA] Remove dependency of ICEView with contacts.js

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S4 (07Aug)
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: borjasalguero, Assigned: borjasalguero)

References

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(1 file)

[gaia] borjasalguero:ice > mozilla-b2g:master
46 bytes, text/x-github-pull-request
arcturus
: review+
Details | Review 
Remove dependencies with contacts.js and export this object to 'window' instead.
Assignee: nobody → borja.bugzilla
Blocks: 1169191
Comment on attachment 8640521 [details] [review]
[gaia] borjasalguero:ice > mozilla-b2g:master

This is needed in order to clean all dependencies of Contacts.js. This will let us to work in the #list view during the WW in Paris.
Attachment #8640521 - Flags: review?(francisco)
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → FxOS-S4 (07Aug)
Status: NEW → ASSIGNED
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
Comment on attachment 8640521 [details] [review]
[gaia] borjasalguero:ice > mozilla-b2g:master

lgtm, we are just changing the namespace.
Attachment #8640521 - Flags: review?(francisco) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: