Closed
Bug 1188924
Opened 9 years ago
Closed 9 years ago
Make centralized workaround function for the issue related to bug 1109213
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
Details
Attachments
(1 file)
Follow-up from bug 1188467.
This workaround code can be found in all kinds of places:
http://mxr.mozilla.org/gaia/search?string=.tap%28x&find=.py&findi=&filter=^[^\0]*%24&hitlimit=&tree=gaia
http://mxr.mozilla.org/gaia/search?string=workaround+for+&find=.py&findi=&filter=^[^\0]*%24&hitlimit=&tree=gaia
We should centralize it, so to avoid code duplication.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8649328 [details] [review]
[gaia] mwargers:1188924 > mozilla-b2g:master
Something like this?
Attachment #8649328 -
Flags: review?(npark)
Attachment #8649328 -
Flags: review?(jlorenzo)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8649328 [details] [review]
[gaia] mwargers:1188924 > mozilla-b2g:master
left one question in the PR about changing frame context. If it's a non-issue. r+ for me.
Attachment #8649328 -
Flags: review?(npark) → review+
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8649328 [details] [review]
[gaia] mwargers:1188924 > mozilla-b2g:master
This looks great!
Attachment #8649328 -
Flags: review?(jlorenzo) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•