1188954 - Manually test the data choices infobar

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Alessio Placitelli [:Dexter]]

It would be great to have a new pair of eyes to double check the following:

* The datachoices infobar (Bug 1137355)
-- The bar is correctly showing on the first run, after 60 seconds (DRS Disabled)
-- The bar is correctly showing on next runs after 10 seconds if the first browser session was closed before 60 seconds (DRS Disabled)
-- We are saving the date the bar was displayed in the prefs (DRS Disabled)
-- The test should be repeated with DRS enabled to make sure we're not regressing the behaviour while DRS is still On.
* Unified telemetry On for people who opted into Telemetry (bug 1182424)

Comment 1

[Alessio Placitelli [:Dexter]]

This is just for the datachoices infobar, I've filed bug 1188969 for the opt-in behaviour.

Comment 2

[Stuart Philp :sphilp]

* The bar is correctly showing on the first run, after 60 seconds
- confirmed with datareporting disabled and enabled

* The bar is correctly showing on next runs after 10 seconds if the first browser session was closed before 60 seconds
- confirmed with datareporting disabled and enabled

* We are saving the date the bar was displayed in the prefs
- Is the pref datareporting.policy.firstRunTime? If so that is being set to the correct timestamp. Otherwise I'm not sure which pref I should be looking at.

Comment 3

[Stuart Philp :sphilp]

This was on nightly/42 btw, using the datareporting.healthreport.service.enabled pref to control DRS

The datareporting.healthreport.uploadenabled pref (the one control via the UI) also seems to make the infobar appear immediately when toggled.

Comment 4

[Georg Fritzsche [:gfritzsche]]

(In reply to Stuart Philp :sphilp from comment #3)
> The datareporting.healthreport.uploadenabled pref (the one control via the
> UI) also seems to make the infobar appear immediately when toggled.

Comment 5

[Alessio Placitelli [:Dexter]]

(In reply to Stuart Philp :sphilp from comment #2)
Thanks Stuart!

> * We are saving the date the bar was displayed in the prefs
> - Is the pref datareporting.policy.firstRunTime? If so that is being set to
> the correct timestamp. Otherwise I'm not sure which pref I should be looking
> at.

Sorry, I wasn't clear about the preferences. The following need to be updated when the bar is displayed:

- "datareporting.policy.dataSubmissionPolicyAcceptedVersion"
- "datareporting.policy.dataSubmissionPolicyNotifiedTime"

Also, the following pref disables all pings upload:

- "datareporting.policy.dataSubmissionEnabled"

> The datareporting.healthreport.uploadenabled pref (the one control via the UI) also seems to make the infobar appear immediately when toggled.

Good catch. When disabling uploadEnabled, a deletion ping gets generated and sent to the server to signal user's intent. Apparently, the Reporting Policy catches this event and shows the infobar.

Comment 6

[Alessio Placitelli [:Dexter]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #4)
> (In reply to Stuart Philp :sphilp from comment #3)
> > The datareporting.healthreport.uploadenabled pref (the one control via the
> > UI) also seems to make the infobar appear immediately when toggled.

I forgot to mention that the bar appears immediately only before the 60s/10s limit. If the infobar was already shown once, it doesn't show again when toggling uploadEnabled.

Comment 7

[Alessio Placitelli [:Dexter]]

I've filed bug 1191336 for the uploadEnabled issue.

Comment 8

[Stuart Philp :sphilp]

Okay, retested with these prefs and can confirm they are set correctly.

One issue:
- create a new profile
- set datareporting.policy.dataSubmissionEnabled to false 
- restart before 60 seconds

Expected:
- The data choices bar displays after 10 seconds

Actual:
- The data choices bar displays after 60 seconds

If you leave datareporting.policy.dataSubmissionEnabled set to true, the bar does show up after 10 seconds, so this pref seems to not hit/support the 10 second case.

Comment 9

[Georg Fritzsche [:gfritzsche]]

Bug 1192314 is not blocking shipping - i think we can close this bug and revisit after bug 1192314 is fixed?

Comment 10

[Stuart Philp :sphilp]

Yup sounds good. Flag me to test the other issue when that's fixed