WebRTC log file is not created on Windows when the TMP env var is set and the default log file name is used

RESOLVED FIXED in Firefox 42

Status

()

Core
WebRTC
P1
normal
Rank:
15
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: pkerr, Assigned: pkerr)

Tracking

39 Branch
mozilla42
x86
Windows
Points:
2

Firefox Tracking Flags

(firefox39 wontfix, firefox40 affected, firefox41 affected, firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
This bug occurs on Windows platforms. When the WebRTC trace log is started by using the "Start Debug Mode" button on the about:webrtc page, and there is no webrtc log file specified using either the WEBRTC_TRACE_FILE environment variable or by setting the media.webrtc.debug.log_file pref, and the TMP environment variable is set then a path with a final forward slash ('/') instead of a backslash ('\') is constructed. Creating this file will fail on a Windows system. A Windows appropriate path separator needs to be used in order for fix this issue.

A work-around for this issue is to set a webrtc log file path using the media.webrtc.debug.log_file pref with a valid Windows path. After that has been set, a log file can be generated by using the 'Start Debug Mode' button.

Updated

3 years ago
Assignee: nobody → pkerr
backlog: --- → webRTC+
Rank: 15
status-firefox39: --- → wontfix
status-firefox40: --- → affected
status-firefox41: --- → affected
status-firefox42: --- → affected
Priority: -- → P1
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8642404 [details] [diff] [review]
WIP

Switch to using nsDirectoryService and nsIFile to generate OS specific paths
(Assignee)

Comment 2

3 years ago
Created attachment 8644615 [details] [diff] [review]
Fix usage of forward slash in constructing webrtc trace file path

Replaced the chain of logic that attempted to determine the location of the temporary
directory with a call to nsDirectoryService.
Use nsIFile object to append file name to path in an OS independent manner.
(Assignee)

Updated

3 years ago
Attachment #8642404 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8644615 - Flags: review?(rjesup)

Updated

3 years ago
Attachment #8644615 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/2fa6cc610bd4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.