Closed Bug 1188970 Opened 4 years ago Closed 4 years ago

WebRTC log file is not created on Windows when the TMP env var is set and the default log file name is used

Categories

(Core :: WebRTC, defect, P1)

39 Branch
x86
Windows
defect
Points:
2

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox39 --- wontfix
firefox40 --- affected
firefox41 --- affected
firefox42 --- fixed
Blocking Flags:

People

(Reporter: pkerr, Assigned: pkerr)

Details

Attachments

(1 file, 1 obsolete file)

This bug occurs on Windows platforms. When the WebRTC trace log is started by using the "Start Debug Mode" button on the about:webrtc page, and there is no webrtc log file specified using either the WEBRTC_TRACE_FILE environment variable or by setting the media.webrtc.debug.log_file pref, and the TMP environment variable is set then a path with a final forward slash ('/') instead of a backslash ('\') is constructed. Creating this file will fail on a Windows system. A Windows appropriate path separator needs to be used in order for fix this issue.

A work-around for this issue is to set a webrtc log file path using the media.webrtc.debug.log_file pref with a valid Windows path. After that has been set, a log file can be generated by using the 'Start Debug Mode' button.
Assignee: nobody → pkerr
backlog: --- → webRTC+
Rank: 15
Priority: -- → P1
Status: NEW → ASSIGNED
Attached patch WIP (obsolete) — Splinter Review
Switch to using nsDirectoryService and nsIFile to generate OS specific paths
Replaced the chain of logic that attempted to determine the location of the temporary
directory with a call to nsDirectoryService.
Use nsIFile object to append file name to path in an OS independent manner.
Attachment #8642404 - Attachment is obsolete: true
Attachment #8644615 - Flags: review?(rjesup)
Attachment #8644615 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/2fa6cc610bd4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.