1189103 - Remove the svg shadow on the icons while we figure out a better solution

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Task Manager, defect)

Description

[Etienne Segonzac (:etienne)]

Sam recently did some profiling and this shadow is costly. Very costly.

I think we should go ahead and simply remove it while we work toward a good enough task manager.

Once we have good performance we'll investigate adding it back with a canvas.

But I feel pretty strongly that the first step here is to get the performance under control.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1189103 > mozilla-b2g:master

Comment 2

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8640767 [details] [review]
[gaia] etiennesegonzac:bug-1189103 > mozilla-b2g:master

Thinking about this, I'm worried that we'll back ourselves into a corner if we just remove the shadows at this point. As it stands, this patch creates a false baseline. Unless we redesign, we do need the shadows and we'll have to add them back - presumably using canvas. At that point we'll need to justify the performance regression that will cause (hopefully substantially less than the SVG approach). 

So either we should provide an alternative implementation in this bug, or file a blocking bug to put them back and meantime instrument the code so we can make informed UX decisions regarding the real cost of this vs. future implementations. We should also link in before & after profiles that capture the problem and demonstrate the saving this change brings to inform UX' decision.

Comment 3

[Francis Djabri [:djabber]]

This may become a non-issue with the task manager redesign - let's see what the visual directions are from Eric. I would say responsiveness would trump the visual appearance - but I'm happy evaluate the performance of taking an alternative approach to the implementation, should we need to do so.

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8640767 [details] [review]
[gaia] etiennesegonzac:bug-1189103 > mozilla-b2g:master

Thanks Francis.
In this light, I'd like to push for this patch again :)

Comment 5

[Etienne Segonzac (:etienne)]

(In reply to Etienne Segonzac (:etienne) from comment #4)
> Comment on attachment 8640767 [details] [review]
> [gaia] etiennesegonzac:bug-1189103 > mozilla-b2g:master
> 
> Thanks Francis.
> In this light, I'd like to push for this patch again :)

To be clearer: regardless of the new visual direction I think we should make the current task manager as fast as possible for 2.5.

Comment 6

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8640767 [details] [review]
[gaia] etiennesegonzac:bug-1189103 > mozilla-b2g:master

Yep, agreed. Also note that if we adopt the web component for displaying icons (currently in use for the new homescreen and being implemented in appchrome as we speak) that implements all the icon decoration through use of a canvas, so we'll be covered there.

Comment 7

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/pull/31165

Comment 8

[Sam Foster [:sfoster] (he/him)]

Master: https://github.com/mozilla-b2g/gaia/commit/28f388e8d72e1520788dc138aeffbad2490ee9f8