Closed Bug 1189128 Opened 9 years ago Closed 9 years ago

Move the easy platform specific devtools theme files into themes/shared/

Categories

(DevTools :: Framework, defect)

Product:
DevTools
Component:
Framework
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(2 files)

MozReview Request: Bug 1189128: Move duplicate CSS files from OS specific folder to shared/devtools;r=jryans
40 bytes, text/x-review-board-request
jryans
: review+
Details
MozReview Request: Bug 1189128 - Rename devtools .inc.css files that are no longer included to .css;r=jryans
40 bytes, text/x-review-board-request
jryans
: review+
Details
Filing this as a first step in Bug 896733. See https://bugzilla.mozilla.org/show_bug.cgi?id=896733#c10. This is just for moving ones that don't have any differences across platforms.
Bug 1189128: Move duplicate CSS files from OS specific folder to shared/devtools;r=jryans
Attachment #8640822 - Flags: review?(jryans)
Bug 1189128 - Rename devtools .inc.css files that are no longer included to .css;r=jryans
Attachment #8640823 - Flags: review?(jryans)
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=37f5201199ae
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment on attachment 8640822 [details] MozReview Request: Bug 1189128: Move duplicate CSS files from OS specific folder to shared/devtools;r=jryans https://reviewboard.mozilla.org/r/14373/#review13215 ::: browser/themes/osx/jar.mn:448 (Diff revision 1) > -* skin/classic/browser/devtools/webaudioeditor.css (devtools/webaudioeditor.css) > +* skin/classic/browser/devtools/webaudioeditor.css (../shared/devtools/webaudioeditor.inc.css) It looks like you forgot to delete `browser/themes/osx/devtools/webaudioeditor.css`.
Attachment #8640822 - Flags: review?(jryans) → review+
Comment on attachment 8640823 [details] MozReview Request: Bug 1189128 - Rename devtools .inc.css files that are no longer included to .css;r=jryans https://reviewboard.mozilla.org/r/14375/#review13217 Ship It!
https://hg.mozilla.org/mozilla-central/rev/9dcb585f9c9d https://hg.mozilla.org/mozilla-central/rev/4b445033a7e6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: