"Assertion failure: NS_IsMainThread()" with WebAudio memory reporter

RESOLVED FIXED in Firefox 42

Status

()

--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jruderman, Assigned: karlt)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla42
assertion, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8640905 [details]
testcase

1. Load the testcase
2. Open about:memory in a new tab
3. Click "Measure"

Assertion failure: NS_IsMainThread(), at AudioNodeEngine.h:348
(Reporter)

Comment 1

3 years ago
Created attachment 8640906 [details]
stacks (crashing thread & main thread)
Karl, that's from you recent cleanup there, right ?
Flags: needinfo?(karlt)
(Assignee)

Comment 3

3 years ago
(In reply to Paul Adenot (:padenot) from comment #2)
> Karl, that's from you recent cleanup there, right ?

Yes, thanks.  The assertion was added in
https://hg.mozilla.org/mozilla-central/rev/c7ddd289198c#l3.32

Thanks Jesse, for the stacks.
Assignee: nobody → karlt
Flags: needinfo?(karlt)
(Assignee)

Updated

3 years ago
Blocks: 914392
(Assignee)

Comment 4

3 years ago
Created attachment 8641442 [details] [diff] [review]
avoid main thread assertion accessing mNode in SizeOfIncludingThis()

because the main thread is blocked during the call.

These nodes are not owned by the engine, and should really be counted on the
main thread, but this is the quick solution without redesigning memory
measurement.
Attachment #8641442 - Flags: review?(padenot)

Updated

3 years ago
Attachment #8641442 - Flags: review?(padenot) → review+
https://hg.mozilla.org/mozilla-central/rev/2c18076d3576
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.