1189168 - "Assertion failure: NS_IsMainThread()" with WebAudio memory reporter

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Load the testcase
2. Open about:memory in a new tab
3. Click "Measure"

Assertion failure: NS_IsMainThread(), at AudioNodeEngine.h:348

Comment 1

[Jesse Ruderman]

Attachment: stacks (crashing thread & main thread)

Comment 2

[Paul Adenot (:padenot)]

Karl, that's from you recent cleanup there, right ?

Comment 3

[Karl Tomlinson (:karlt)]

(In reply to Paul Adenot (:padenot) from comment #2)
> Karl, that's from you recent cleanup there, right ?

Yes, thanks.  The assertion was added in
https://hg.mozilla.org/mozilla-central/rev/c7ddd289198c#l3.32

Thanks Jesse, for the stacks.

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: avoid main thread assertion accessing mNode in SizeOfIncludingThis()

because the main thread is blocked during the call.

These nodes are not owned by the engine, and should really be counted on the
main thread, but this is the quick solution without redesigning memory
measurement.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c18076d3576

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c18076d3576