1189171 - New startup terminalspew: "WARNING: the property getUserMedia.sharingMenuMicrophoneApplication already exists : file xpcom/ds/nsPersistentProperties.cpp, line 532"

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Daniel Holbert [:dholbert]]

New startup terminalspew, introduced in the last few days I think (in debug builds):
{
[21627] WARNING: the property getUserMedia.sharingMenuMicrophoneApplication already exists
: file /scratch/work/builds/mozilla-inbound/mozilla/xpcom/ds/nsPersistentProperties.cpp, line 532
[21627] WARNING: the property getUserMedia.sharingMenuMicrophoneScreen already exists
: file /scratch/work/builds/mozilla-inbound/mozilla/xpcom/ds/nsPersistentProperties.cpp, line 532
[21627] WARNING: the property getUserMedia.sharingMenuMicrophoneWindow already exists
: file /scratch/work/builds/mozilla-inbound/mozilla/xpcom/ds/nsPersistentProperties.cpp, line 532
[21627] WARNING: the property getUserMedia.sharingMenuMicrophoneBrowser already exists
: file /scratch/work/builds/mozilla-inbound/mozilla/xpcom/ds/nsPersistentProperties.cpp, line 532
}

Comment 1

[Daniel Holbert [:dholbert]]

Looks like this is telling us that we have two values for this string property in browser.properties. In particular:
> 667 getUserMedia.sharingMenuMicrophoneScreen = %S (microphone and screen)
[...]
> 671 getUserMedia.sharingMenuMicrophoneScreen = %S (tab audio and screen)
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.properties

The latter line was added recently in http://hg.mozilla.org/mozilla-central/rev/235175205cde for bug 1156472.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> Looks like this is telling us that we have two values for this string
> property in browser.properties.

Er, for multiple strings (not just one). I hadn't noticed, but the warnings are all slightly different -- they're for:
 sharingMenuMicrophoneApplication
 sharingMenuMicrophoneScreen
 sharingMenuMicrophoneWindow
 sharingMenuMicrophoneBrowser
all of which have duplicate definitions.

Paul, can you clean this up & pick whichever value is correct for these strings?

Comment 4

[Paul Adenot (:padenot)]

Attachment: Put proper id for the audio capture strings. r=

This should do it.

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8642278 [details] [diff] [review]
Put proper id for the audio capture strings. r=

Please also update the list of strings in the localization note at http://hg.mozilla.org/mozilla-central/file/32712cd01159/browser/locales/en-US/chrome/browser/browser.properties#l619

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f3c55093831

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0f3c55093831