Closed Bug 1189315 Opened 10 years ago Closed 10 years ago

[Bluetooth] Add daemon interface for HFP WBS callback

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(feature-b2g:2.2r+, firefox43 fixed, b2g-v2.2r fixed)

RESOLVED FIXED
FxOS-S6 (04Sep)
feature-b2g 2.2r+
Tracking Status
firefox43 --- fixed
b2g-v2.2r --- fixed

People

(Reporter: wiwang, Assigned: ben.tian)

References

Details

Attachments

(2 files, 1 obsolete file)

As description in bug 1189292, "BlueZ 5.32 is missing hf_wbs_callback notification implementation", therefore we need to add corresponding daemon interface for HFP WBS callback as well.
Blocks: 911635
Set assignee to Ben since he had already wrote a patch :) Hi Ben, Thanks for your patch!
Assignee: nobody → btian
Attachment #8641603 - Flags: review?(tzimmermann)
Comment on attachment 8641603 [details] [diff] [review] Patch 1 (v1): Add daemon interface for HFP WBS callback Will, please help verify whether this gecko patch works for WBS callback. Thanks.
Attachment #8641603 - Flags: feedback?(wiwang)
Comment on attachment 8641603 [details] [diff] [review] Patch 1 (v1): Add daemon interface for HFP WBS callback Review of attachment 8641603 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Please don't land this patch before BlueZ lists the callback in their IPC spec.
Attachment #8641603 - Flags: review?(tzimmermann) → review+
Comment on attachment 8641603 [details] [diff] [review] Patch 1 (v1): Add daemon interface for HFP WBS callback Hi Ben, Verification is passed in PTS tests[1] and parameter is correctly received by audio manager, thanks for your patch! [1] TC_AG_WBS_BV_01_I TC_AG_SLC_BV_05_I TC_AG_SLC_BV_06_I
Attachment #8641603 - Flags: feedback?(wiwang) → feedback+
Patch has been slightly modified for [1] and pushed to try server[2], wait for try result. [1] https://hg.mozilla.org/mozilla-central/diff/7b3e0ca41320/dom/bluetooth/bluedroid/BluetoothDaemonHandsfreeInterface.cpp#l1.145 [2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ff50e21f8e8 try syntax: build KK and L only, test none.
Attach patch which passed the above try test. Carry r+ from previous patch
Attachment #8641603 - Attachment is obsolete: true
Attachment #8655898 - Flags: review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S6 (04Sep)
I have already rebased the original m-c patch (comment 8) to branch 2.2r as well, and will attach/ask for checkin-needed once the patch in bug 911635 get r+.
Attachment #8655898 - Attachment description: Patch 1 (v2): Add daemon interface for HFP WBS callback → Patch 1 (v2): Add daemon interface for HFP WBS callback (for m-c)
Rebased patch for branch 2.2r, carry r+ from previous patch.
Attachment #8658119 - Flags: review+
Hi Wesley, Could you help to set 2.2r+ for patch landing? Thanks!
blocking-b2g: --- → 2.2r?
Flags: needinfo?(whuang)
Keywords: checkin-needed
blocking-b2g: 2.2r? → ---
feature-b2g: --- → 2.2r+
Flags: needinfo?(whuang)
Attachment #8655898 - Attachment description: Patch 1 (v2): Add daemon interface for HFP WBS callback (for m-c) → (for m-c) Patch 1 (v2): Add daemon interface for HFP WBS callback
Attachment #8658119 - Attachment description: Patch: Add daemon interface for HFP WBS callback (for branch 2.2r) → (for branch 2.2r) Patch: Add daemon interface for HFP WBS callback
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: