1189315 - [Bluetooth] Add daemon interface for HFP WBS callback

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Will Wang [:WillWang]]

As description in bug 1189292, "BlueZ 5.32 is missing hf_wbs_callback notification implementation", therefore we need to add corresponding daemon interface for HFP WBS callback as well.

Comment 1

[Will Wang [:WillWang]]

We can refer to the following code snippets:

https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/BluetoothDaemonHandsfreeInterface.h#263-266

https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/BluetoothDaemonHandsfreeInterface.cpp#1099-1141

Comment 2

[Will Wang [:WillWang]]

Set assignee to Ben since he had already wrote a patch :)

Hi Ben,

Thanks for your patch!

Comment 3

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): Add daemon interface for HFP WBS callback

Comment 4

[Ben Tian (inactive)]

Comment on attachment 8641603 [details] [diff] [review]
Patch 1 (v1): Add daemon interface for HFP WBS callback

Will, please help verify whether this gecko patch works for WBS callback. Thanks.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8641603 [details] [diff] [review]
Patch 1 (v1): Add daemon interface for HFP WBS callback

Review of attachment 8641603 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Please don't land this patch before BlueZ lists the callback in their IPC spec.

Comment 6

[Will Wang [:WillWang]]

Comment on attachment 8641603 [details] [diff] [review]
Patch 1 (v1): Add daemon interface for HFP WBS callback

Hi Ben,

Verification is passed in PTS tests[1] and parameter is correctly received by audio manager, thanks for your patch!

[1]
TC_AG_WBS_BV_01_I
TC_AG_SLC_BV_05_I
TC_AG_SLC_BV_06_I

Comment 7

[Will Wang [:WillWang]]

Patch has been slightly modified for [1] and pushed to try server[2],
wait for try result.

[1]
https://hg.mozilla.org/mozilla-central/diff/7b3e0ca41320/dom/bluetooth/bluedroid/BluetoothDaemonHandsfreeInterface.cpp#l1.145

[2]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ff50e21f8e8
try syntax: build KK and L only, test none.

Comment 8

[Will Wang [:WillWang]]

Attachment: (for m-c) Patch 1 (v2): Add daemon interface for HFP WBS callback

Attach patch which passed the above try test.
Carry r+ from previous patch

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/ca185abaecc5

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca185abaecc5

Comment 11

[Will Wang [:WillWang]]

I have already rebased the original m-c patch (comment 8) to branch 2.2r as well,
and will attach/ask for checkin-needed once the patch in bug 911635 get r+.

Comment 12

[Will Wang [:WillWang]]

Attachment: (for branch 2.2r) Patch: Add daemon interface for HFP WBS callback

Rebased patch for branch 2.2r,
carry r+ from previous patch.

Comment 13

[Will Wang [:WillWang]]

Hi Wesley,

Could you help to set 2.2r+ for patch landing?
Thanks!

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/51b256f69a43