[Bluetooth] Add daemon interface for HFP WBS callback
RESOLVED
FIXED
in Firefox 43, Firefox OS v2.2r
Status
People
(Reporter: wiwang, Assigned: ben.tian)
Tracking
Firefox Tracking Flags
(feature-b2g:2.2r+, firefox43 fixed, b2g-v2.2r fixed)
Details
Attachments
(2 attachments, 1 obsolete attachment)
|
6.78 KB,
patch
|
wiwang
:
review+
|
Details | Diff | Splinter Review |
|
7.26 KB,
patch
|
wiwang
:
review+
|
Details | Diff | Splinter Review |
As description in bug 1189292, "BlueZ 5.32 is missing hf_wbs_callback notification implementation", therefore we need to add corresponding daemon interface for HFP WBS callback as well.
|
(Reporter) | |
Comment 1•3 years ago
|
||
We can refer to the following code snippets: https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/BluetoothDaemonHandsfreeInterface.h#263-266 https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/BluetoothDaemonHandsfreeInterface.cpp#1099-1141
|
|
(Reporter) | |
Comment 2•3 years ago
|
||
Set assignee to Ben since he had already wrote a patch :) Hi Ben, Thanks for your patch!
Assignee: nobody → btian
|
(Assignee) | |
Comment 3•3 years ago
|
||
Created attachment 8641603 [details] [diff] [review] Patch 1 (v1): Add daemon interface for HFP WBS callback
Attachment #8641603 -
Flags: review?(tzimmermann)
|
|
(Assignee) | |
Comment 4•3 years ago
|
||
Comment on attachment 8641603 [details] [diff] [review] Patch 1 (v1): Add daemon interface for HFP WBS callback Will, please help verify whether this gecko patch works for WBS callback. Thanks.
Attachment #8641603 -
Flags: feedback?(wiwang)
|
||
Comment 5•3 years ago
|
||
Comment on attachment 8641603 [details] [diff] [review] Patch 1 (v1): Add daemon interface for HFP WBS callback Review of attachment 8641603 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Please don't land this patch before BlueZ lists the callback in their IPC spec.
Attachment #8641603 -
Flags: review?(tzimmermann) → review+
|
|
||
Updated•3 years ago
|
||
See Also: → bug 1189292
|
|
(Reporter) | |
Comment 6•3 years ago
|
||
Comment on attachment 8641603 [details] [diff] [review] Patch 1 (v1): Add daemon interface for HFP WBS callback Hi Ben, Verification is passed in PTS tests[1] and parameter is correctly received by audio manager, thanks for your patch! [1] TC_AG_WBS_BV_01_I TC_AG_SLC_BV_05_I TC_AG_SLC_BV_06_I
Attachment #8641603 -
Flags: feedback?(wiwang) → feedback+
|
|
(Reporter) | |
Comment 7•3 years ago
|
||
Patch has been slightly modified for [1] and pushed to try server[2], wait for try result. [1] https://hg.mozilla.org/mozilla-central/diff/7b3e0ca41320/dom/bluetooth/bluedroid/BluetoothDaemonHandsfreeInterface.cpp#l1.145 [2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ff50e21f8e8 try syntax: build KK and L only, test none.
|
|
(Reporter) | |
Comment 8•3 years ago
|
||
Created attachment 8655898 [details] [diff] [review] (for m-c) Patch 1 (v2): Add daemon interface for HFP WBS callback Attach patch which passed the above try test. Carry r+ from previous patch
Attachment #8641603 -
Attachment is obsolete: true
Attachment #8655898 -
Flags: review+
|
|
(Reporter) | |
Updated•3 years ago
|
||
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/ca185abaecc5
Keywords: checkin-needed
|
||
Comment 10•3 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ca185abaecc5
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S6 (04Sep)
|
|
(Reporter) | |
Comment 11•3 years ago
|
||
I have already rebased the original m-c patch (comment 8) to branch 2.2r as well, and will attach/ask for checkin-needed once the patch in bug 911635 get r+.
|
|
(Reporter) | |
Updated•3 years ago
|
||
Attachment #8655898 -
Attachment description: Patch 1 (v2): Add daemon interface for HFP WBS callback → Patch 1 (v2): Add daemon interface for HFP WBS callback (for m-c)
|
|
(Reporter) | |
Comment 12•3 years ago
|
||
Created attachment 8658119 [details] [diff] [review] (for branch 2.2r) Patch: Add daemon interface for HFP WBS callback Rebased patch for branch 2.2r, carry r+ from previous patch.
Attachment #8658119 -
Flags: review+
|
|
(Reporter) | |
Comment 13•3 years ago
|
||
Hi Wesley, Could you help to set 2.2r+ for patch landing? Thanks!
blocking-b2g: --- → 2.2r?
status-b2g-v2.2r: --- → affected
Flags: needinfo?(whuang)
Keywords: checkin-needed
|
||
Updated•3 years ago
|
||
blocking-b2g: 2.2r? → ---
feature-b2g: --- → 2.2r+
Flags: needinfo?(whuang)
|
|
(Reporter) | |
Updated•3 years ago
|
||
Attachment #8655898 -
Attachment description: Patch 1 (v2): Add daemon interface for HFP WBS callback (for m-c) → (for m-c) Patch 1 (v2): Add daemon interface for HFP WBS callback
|
|
(Reporter) | |
Updated•3 years ago
|
||
Attachment #8658119 -
Attachment description: Patch: Add daemon interface for HFP WBS callback (for branch 2.2r) → (for branch 2.2r) Patch: Add daemon interface for HFP WBS callback
|
||
Comment 14•3 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/51b256f69a43
status-b2g-v2.2r: affected → fixed
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•