1189399 - [Keyboard] Typing on keyboard produces flickering, graphical issues.

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-keyboard.txt

Description:
When the user types on the keyboard, the key selection, capitalization, and switching to numbers will cause the keyboard to show a lot of flickering, blank keys, extra key selection bubbles, etc.

This appears to occur in all text fields with all keyboard types.

Repro Steps:
1) Update a Aries to 20150730145424
2) Open the rocketbar and begin typing.

Actual:
Keyboard flickers, and there are graphical artifacts from selected keys, blank keys.

Expected:
The keyboard will not flicker, and will consistently appear properly

Environmental Variables:
Device: Aries 2.5
Build ID: 20150730145424
Gaia: 1d3595836bd55b70478923d771051268a5dabf91
Gecko: 305ba37a62f8
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
Link to failed test case:
See attached: screenshot, logcat

------------------------------------------------

This issue DOES occur on Flame 2.5 builds.
The keyboard appears all black on a 1024MB Flame, and will flicker black on a 319MB Flame.

Environmental Variables:
Device: Flame 2.5
Build ID: 20150730030209
Gaia: bf8565e0c3ad216ccb3f109c17f8a2eb2c42f6b8
Gecko: 62469b20ec84
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 1

[Martin Shuman [:Marty]]

Attachment: keyboard_screenshot

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Functional regression of a core feature (keyboard) that fails smoke tests.

Requesting a window.

Comment 3

[Duane Dixon [:ddixon]]

Mozilla Inbound Regression Window

Last Working 
Device: Flame 2.5
BuildID: 20150729104042
Gaia: bbf14824939479074049ff4c3888614794c4cec1
Gecko: 646c99efe919
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 42.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

First Broken 
Device: Flame 2.5
BuildID: 20150729104243
Gaia: bbf14824939479074049ff4c3888614794c4cec1
Gecko: 69871c00379b
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 42.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Last Working Gaia and First Broken Gecko
Issue DOES occur here: 
Gaia: bbf14824939479074049ff4c3888614794c4cec1
Gecko: 69871c00379b

Last Working Gecko and First Broken Gaia
Issue DOES NOT occur here:  
Gaia: bbf14824939479074049ff4c3888614794c4cec1
Gecko: 646c99efe919

Mozilla Inbound Pushlog (Gecko): 
hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=646c99efe919&tochange=69871c00379b

Probable Cause: 
Bug 1180326 - Create a new ContentClient that supports async transaction without minimum size

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Matt, can you take a look at this please? This appears to be another fallout from the landing for bug 1180326.

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Disable SingleTiledContentClient for b2g

Comment 6

[No-Jun Park [:njpark]]

Perhaps it's related, on 319MB flame, running b2g-ps shouls Built-in Keyboard process, which shouldn't be there when I'm on homscreen right after the bootup:

APPLICATION    SEC USER     PID   PPID  VSIZE  RSS     WCHAN    PC         NAME
b2g              0 root      212   1     251204 97572 ffffffff b6ea4894 S /system/b2g/b2g
(Nuwa)           0 root      455   212   97972  17580 ffffffff b6ea4894 S /system/b2g/b2g
Homescreen       2 u0_a973   973   455   175560 47008 ffffffff b6ea4894 S /system/b2g/b2g
Built-in Keyboa  2 u0_a1135  1135  455   127208 29212 ffffffff b6ea4894 S /system/b2g/b2g
(Preallocated a  2 u0_a1317  1317  455   111988 26128 ffffffff b6ea4894 S /system/b2g/b2g

Comment 7

[[:fabrice] Fabrice Desré]

Comment on attachment 8641217 [details] [diff] [review]
Disable SingleTiledContentClient for b2g

Review of attachment 8641217 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/ClientPaintedLayer.cpp
@@ +152,5 @@
>  ClientLayerManager::CreatePaintedLayerWithHint(PaintedLayerCreationHint aHint)
>  {
>    NS_ASSERTION(InConstruction(), "Only allowed in construction phase");
> +  if (
> +#ifdef MOZ_B2G

MOZ_B2G is also set on desktop b2g builds, and on the browser.html runtime. If you want something which is device only, use MOZ_WIDGET_GONK instead.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8641217 [details] [diff] [review]
Disable SingleTiledContentClient for b2g

Review of attachment 8641217 [details] [diff] [review]:
-----------------------------------------------------------------

Poor B2G

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/104b0bbd714f

Comment 10

[[:fabrice] Fabrice Desré]

Why did we disable that on b2g destop too?

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/104b0bbd714f

Comment 12

[Matt Woodrow (:mattwoodrow)]

(In reply to [:fabrice] NOT READING BUGMAIL UNTIL JULY 27 from comment #10)
> Why did we disable that on b2g destop too?

This is the same configuration as we had before, I essentially just backed out the changes I made to switch to my new code.

It was probably unnecessary, but I figured it was easier to go with what we know works.

Comment 13

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfbd02568bdb

Comment 14

[Jamie Charlton (:Jamie_)]

verified fixed on the flame

Environmental Variables:
Device: Flame Master
Build ID: 20150802030210
Gaia: 2ca27bbdd84526c6a3b198d9cf10f2caff1dadde
Gecko: 32712cd01159
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 42.0a1 (Master)
Firmware Version: v18D_nightly_v4
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 15

[Shally Li（leave from Mozilla）]

Per comment 14, change the 'status-b2g-master' to 'verified'.

Comment 16

[Martin Shuman [:Marty]]

Removing qaurgent keyword.

Comment 17

[Johan Lorenzo [:jlorenzo]]

Moving the bug to the component where the regression came from.