Closed Bug 1189453 Opened 4 years ago Closed 4 years ago

"Learn more" link in private browsing tracking protection should open in Private Browsing

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 42
Tracking Status
firefox42 --- verified

People

(Reporter: liuche, Assigned: Margaret)

References

Details

Attachments

(1 file)

Since Tracking Protection is enabled by default in Private Browsing, we should make sure the "Learn more" link matches the browsing state you're in.
Bug 1189453 - Update loadUrlInTab to load the URL in the same private context as its parent tab. r=liuche
Attachment #8643245 - Flags: review?(liuche)
Assignee: nobody → margaret.leibovic
This might be scope creep, but I feel like we should always open new tabs in the same context as the parent tab, especially if we're setting a parentId on the new tab.
Attachment #8643245 - Flags: review?(liuche) → review+
Comment on attachment 8643245 [details]
MozReview Request: Bug 1189453 - Update loadUrlInTab to load the URL in the same private context as its parent tab. r=liuche

https://reviewboard.mozilla.org/r/15003/#review13637

Ship It!

::: mobile/android/base/Tabs.java:996
(Diff revision 1)
> -        loadUrl(url, null, parentId, LOADURL_NEW_TAB);
> +        loadUrl(url, null, parentId, flags  );

Nit: extra spaces here
url:        https://hg.mozilla.org/integration/fx-team/rev/7ca5e33f197246142b5478fbc147af6caa5aa512
changeset:  7ca5e33f197246142b5478fbc147af6caa5aa512
user:       Margaret Leibovic <margaret.leibovic@gmail.com>
date:       Tue Aug 04 16:24:43 2015 -0400
description:
Bug 1189453 - Update loadUrlInTab to load the URL in the same private context as its parent tab. r=liuche
Duplicate of this bug: 1190006
https://hg.mozilla.org/mozilla-central/rev/7ca5e33f1972
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Tapping the "Learn more" link in private browsing from the tracking protection doorhanger, opens the page in Private Browsing, so verified as fixed using:
Device: Samsung S5 (Android 4.4.2)
Build: Firefox for Android 42.0a1 (2015-08-09)
Verified as fixed using:
Device: Samsung S6 Edge (Android 5.1)
Build: Firefox for Android 42 beta 1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.