1189453 - "Learn more" link in private browsing tracking protection should open in Private Browsing

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Since Tracking Protection is enabled by default in Private Browsing, we should make sure the "Learn more" link matches the browsing state you're in.

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1189453 - Update loadUrlInTab to load the URL in the same private context as its parent tab. r=liuche

Bug 1189453 - Update loadUrlInTab to load the URL in the same private context as its parent tab. r=liuche

Comment 2

[:Margaret Leibovic]

This might be scope creep, but I feel like we should always open new tabs in the same context as the parent tab, especially if we're setting a parentId on the new tab.

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8643245 [details]
MozReview Request: Bug 1189453 - Update loadUrlInTab to load the URL in the same private context as its parent tab. r=liuche

https://reviewboard.mozilla.org/r/15003/#review13637

Ship It!

::: mobile/android/base/Tabs.java:996
(Diff revision 1)
> -        loadUrl(url, null, parentId, LOADURL_NEW_TAB);
> +        loadUrl(url, null, parentId, flags  );

Nit: extra spaces here

Comment 4

[:Margaret Leibovic]

url:        https://hg.mozilla.org/integration/fx-team/rev/7ca5e33f197246142b5478fbc147af6caa5aa512
changeset:  7ca5e33f197246142b5478fbc147af6caa5aa512
user:       Margaret Leibovic <[e-mail]>
date:       Tue Aug 04 16:24:43 2015 -0400
description:
Bug 1189453 - Update loadUrlInTab to load the URL in the same private context as its parent tab. r=liuche

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ca5e33f1972

Comment 7

[Teodora Vermesan (:TeoVermesan)]

Tapping the "Learn more" link in private browsing from the tracking protection doorhanger, opens the page in Private Browsing, so verified as fixed using:
Device: Samsung S5 (Android 4.4.2)
Build: Firefox for Android 42.0a1 (2015-08-09)

Comment 8

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed using:
Device: Samsung S6 Edge (Android 5.1)
Build: Firefox for Android 42 beta 1