118953 - Incorrect message from checksetup.pl

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P4)

Description

[Adam Kennedy]

When a module is installed but the version isn't new enough, checksetup.pl 
issues the following warning ( I'll just dump the code ).

if (@missing > 0) {
    print "\n\n";
    print "You are missing some Perl modules which are required by Bugzilla.\n";
    print "They can be installed by running (as root) the following:\n";
    foreach my $module (@missing) {
        print "   perl -MCPAN -e 'install \"$module\"'\n";
    }
    print "\n";
    exit;
}

The message is wrong, and should be changed to something like

"Bugzilla requires some Perl modules which are either missing from your system, 
or the version on your system is too old."

This is a good idea in general, but is going to cause less headaches when the 
patch for Bug 67663 goes in, and people upgrading won't have a new enough 
version of CGI::Carp.

Comment 1

[Adam Kennedy]

Attachment: Text message change

Adding patch to change the message

Comment 2

[Adam Kennedy]

Adding patch, review keywords.

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 64130 [details] [diff] [review]
Text message change

>Index: checksetup.pl
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v
>retrieving revision 1.112
>diff -u -r1.112 checksetup.pl
>--- checksetup.pl	2001/12/12 22:41:04	1.112
>+++ checksetup.pl	2002/01/09 14:27:13
>@@ -224,8 +224,9 @@
> }
> if (@missing > 0) {
>     print "\n\n";
>-    print "You are missing some Perl modules which are required by Bugzilla.\n";
>-    print "They can be installed by running (as root) the following:\n";
>+    print "Bugzilla requires some Perl modules which are either missing from your\n",
>+    "system, or the version on your system is too old.",

This line needs a \n after it.

r=bbaetz with that - I'll attach a new patch

>+    "They can be installed by running (as root) the following:\n";
>     foreach my $module (@missing) {
>         print "   perl -MCPAN -e 'install \"$module\"'\n";
>     }

Comment 4

[Bradley Baetz (:bbaetz)]

-> 2.16, patch author

Comment 5

[Bradley Baetz (:bbaetz)]

Attachment: new patch

Comment 6

[Bradley Baetz (:bbaetz)]

Comment on attachment 74695 [details] [diff] [review]
new patch

r=bbaetz on this. Would be x 2, but I did change it slightly, so I probably
shouldn't.

Actually, maybe this should be "version(s)", or otherwise split
singular/plural?

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 74695 [details] [diff] [review]
new patch

r= justdave

Comment 8

[Bradley Baetz (:bbaetz)]

Checked in, thanks