Rename synchronize to unsafeSynchronize to encourage callers to think twice

RESOLVED FIXED in Firefox 42

Status

RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
Firefox 42

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
Created attachment 8641558 [details] [diff] [review]
Rename synchronize to unsafeSynchronize to encourage callers to think twice
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #8641558 - Flags: review?(ttromey)
Created attachment 8641573 [details] [diff] [review]
Rename synchronize to unsafeSynchronize to encourage callers to think twice
Attachment #8641558 - Attachment is obsolete: true
Attachment #8641558 - Flags: review?(ttromey)
Comment on attachment 8641573 [details] [diff] [review]
Rename synchronize to unsafeSynchronize to encourage callers to think twice

Last version did not update tests that called synchronize.
Attachment #8641573 - Flags: review?(ttromey)
Created attachment 8641770 [details] [diff] [review]
Rename synchronize to unsafeSynchronize to encourage callers to think twice
Attachment #8641573 - Attachment is obsolete: true
Attachment #8641573 - Flags: review?(ttromey)
Comment on attachment 8641770 [details] [diff] [review]
Rename synchronize to unsafeSynchronize to encourage callers to think twice

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7735f0307c90
Attachment #8641770 - Flags: review?(jsantell)
Comment on attachment 8641770 [details] [diff] [review]
Rename synchronize to unsafeSynchronize to encourage callers to think twice

Review of attachment 8641770 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe it's obvious for those working in this area, but maybe a mention in the unsafeSynchronize function comments why this is unsafe, and the preferred/more safe way to do this, or what the exceptions are for why one should call this in the first place
Attachment #8641770 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/d4446e517b3a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.