1189647 - Rename synchronize to unsafeSynchronize to encourage callers to think twice

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Rename synchronize to unsafeSynchronize to encourage callers to think twice

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Rename synchronize to unsafeSynchronize to encourage callers to think twice

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8641573 [details] [diff] [review]
Rename synchronize to unsafeSynchronize to encourage callers to think twice

Last version did not update tests that called synchronize.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Rename synchronize to unsafeSynchronize to encourage callers to think twice

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8641770 [details] [diff] [review]
Rename synchronize to unsafeSynchronize to encourage callers to think twice

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7735f0307c90

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8641770 [details] [diff] [review]
Rename synchronize to unsafeSynchronize to encourage callers to think twice

Review of attachment 8641770 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe it's obvious for those working in this area, but maybe a mention in the unsafeSynchronize function comments why this is unsafe, and the preferred/more safe way to do this, or what the exceptions are for why one should call this in the first place

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d4446e517b3a

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d4446e517b3a