1189655 - define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Makoto Kato [:m_kato]]

by http://blogs.msdn.com/b/vcblog/archive/2015/06/02/constexpr-complete-for-vs-2015-rtm-c-11-compiler-c-17-stl.aspx, we will able to define MOZ_HAVE_CXX11_CONSTEXPR even if VS2015.

Comment 1

[Makoto Kato [:m_kato]]

We cannot compile HTMLTrackElement.cpp using constexpr.

Filed as https://connect.microsoft.com/VisualStudio/feedback/details/1611942/constexpr-causes-internal-compiler-error

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

AFAICT, this doesn't block enabling VS2015, so changing dependencies accordingly.

(In reply to Makoto Kato [:m_kato] from comment #1)
> We cannot compile HTMLTrackElement.cpp using constexpr.
> 
> Filed as
> https://connect.microsoft.com/VisualStudio/feedback/details/1611942/
> constexpr-causes-internal-compiler-error

Until that bug is fixed, we can either just not define MOZ_HAVE_CXX11_CONSTEXPR, or temporarily change the HTMLTrackElement stuff to avoid constexpr when building with Visual Studio.

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

Attachment: MozReview Request: Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r?waldo

Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r?waldo

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

(In reply to Brian Smith (:briansmith, :bsmith, use NEEDINFO?) from comment #2)
> Until that bug is fixed, we can either just not define
> MOZ_HAVE_CXX11_CONSTEXPR, or temporarily change the HTMLTrackElement stuff
> to avoid constexpr when building with Visual Studio.

We need to do neither one. That internal error is easy to workaround.

Comment 5

[Jeff Walden [:Waldo]]

Comment on attachment 8650403 [details]
MozReview Request: Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r?waldo

https://reviewboard.mozilla.org/r/16623/#review14935

Ship It!

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a5420073ea387c4c74814beca323af365b793e4c
changeset:  a5420073ea387c4c74814beca323af365b793e4c
user:       Xidorn Quan <[e-mail]>
date:       Fri Aug 21 09:17:18 2015 +1000
description:
Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r=Waldo

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a5420073ea38