Closed Bug 1189677 Opened 5 years ago Closed 5 years ago

Only add scripts to the ScriptStore if we intend to debug their source

Categories

(DevTools :: Debugger, defect)

defect
Not set

Tracking

(firefox42 fixed)

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #8641578 - Flags: review?(ttromey)
Comment on attachment 8641774 [details] [diff] [review]
Only add scripts to the ScriptStore if we intend to debug their source

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0da3b4495889
Attachment #8641774 - Flags: review?(jsantell)
Comment on attachment 8641774 [details] [diff] [review]
Only add scripts to the ScriptStore if we intend to debug their source

Review of attachment 8641774 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/script.js
@@ +1898,5 @@
>      if (!this.sources.allowSource(aSource)) {
>        return false;
>      }
>  
> +    // XXX: The scripts must be added to the ScriptStore before restoring

No reason for the XXX anymore (is that usually for TODOs?) and mention the reason that this is done after the allowSource check (essentially the whole reason for this move)
Attachment #8641774 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/700412857434
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.