1189677 - Only add scripts to the ScriptStore if we intend to debug their source

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Only add scripts to the ScriptStore if we intend to debug their source

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Only add scripts to the ScriptStore if we intend to debug their source

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8641774 [details] [diff] [review]
Only add scripts to the ScriptStore if we intend to debug their source

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0da3b4495889

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8641774 [details] [diff] [review]
Only add scripts to the ScriptStore if we intend to debug their source

Review of attachment 8641774 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/script.js
@@ +1898,5 @@
>      if (!this.sources.allowSource(aSource)) {
>        return false;
>      }
>  
> +    // XXX: The scripts must be added to the ScriptStore before restoring

No reason for the XXX anymore (is that usually for TODOs?) and mention the reason that this is done after the allowSource check (essentially the whole reason for this move)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/700412857434

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/700412857434