Closed
Bug 1189678
Opened 9 years ago
Closed 9 years ago
"Harness status: ERROR" when running "onactivate-script-error.https.html" test
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox42 affected, firefox43 fixed)
RESOLVED
FIXED
mozilla43
People
(Reporter: noemi, Assigned: nsm)
References
Details
Attachments
(1 file)
Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/onactivate-script-error.https.html|
Actual Result:
Harness status: Error
Error: error at level 1
Found 5 tests
5 Fail
* activate handler throws an error
** promise_test: Unhandled rejection with value: object "TypeError: worker is null"
make_test@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:30:1
@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:67:5
@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:45:1
* activate handler throws an error, error handler does not cancel
** promise_test: Unhandled rejection with value: object "TypeError: worker is null"
make_test@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:30:1
@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:67:5
@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:45:1
* activate handler dispatches an event that throws an error
** promise_test: Unhandled rejection with value: object "TypeError: worker is null"
make_test@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:30:1
@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:67:5
@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:45:1
* activate handler throws an error that is cancelled
** promise_test: Unhandled rejection with value: object "TypeError: worker is null"
make_test@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:30:1
@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:67:5
@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:45:1
* activate handler throws an error and prevents default
** promise_test: Unhandled rejection with value: object "TypeError: worker is null"
make_test@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:30:1
@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:67:5
@https://web-platform.test:8443/_mozilla/service-workers/service-worker/onactivate-script-error.https.html:45:1
Traces: https://pastebin.mozilla.org/8838613
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1189678 - check if worker is already active. r?bkelly
Similar to other tests, the registration process allows workers to activate right after install.
Update web-platform-tests expected data
Attachment #8651320 -
Flags: review?(bkelly)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8651320 [details]
MozReview Request: Bug 1189678 - check if worker is already active. r?bkelly
https://reviewboard.mozilla.org/r/16917/#review15143
Ship It!
Attachment #8651320 -
Flags: review?(bkelly) → review+
Assignee | ||
Comment 3•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/d4fa5cfc4b8634f6b74cc687d2ec8f8b5103727c
changeset: d4fa5cfc4b8634f6b74cc687d2ec8f8b5103727c
user: Nikhil Marathe <nsm.nikhil@gmail.com>
date: Fri Aug 21 17:55:50 2015 -0700
description:
Bug 1189678 - check if worker is already active. r=bkelly
Similar to other tests, the registration process allows workers to activate right after install.
Update web-platform-tests expected data
Assignee | ||
Comment 4•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/1ea2ebce35fe82f201e5da42aa874ca5ad41ac39
changeset: 1ea2ebce35fe82f201e5da42aa874ca5ad41ac39
user: Nikhil Marathe <nsm.nikhil@gmail.com>
date: Fri Aug 21 17:55:50 2015 -0700
description:
Bug 1189678 - check if worker is already active. r=bkelly
Similar to other tests, the registration process allows workers to activate right after install.
Update web-platform-tests expected data
Comment 8•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Reporter | ||
Comment 9•9 years ago
|
||
Hi,
just checked on m-c (c46370eea81a revision) and all the tests successfully run although the harness status still remains as ERROR. Should we open a new bug to track this?.
Summary
Harness status: Error
Error: error at level 1
Found 5 tests
5 Pass
Details
Result Test Name
Pass activate handler throws an error
Pass activate handler throws an error, error handler does not cancel
Pass activate handler dispatches an event that throws an error
Pass activate handler throws an error that is cancelled
Pass activate handler throws an error and prevents default
Flags: needinfo?(nsm.nikhil)
Assignee | ||
Comment 10•9 years ago
|
||
(In reply to Noemí Freire (:noemi) from comment #9)
> Hi,
>
> just checked on m-c (c46370eea81a revision) and all the tests successfully
> run although the harness status still remains as ERROR. Should we open a new
> bug to track this?.
>
> Summary
>
> Harness status: Error
>
> Error: error at level 1
>
> Found 5 tests
> 5 Pass
> Details
> Result Test Name
> Pass activate handler throws an error
> Pass activate handler throws an error, error handler does not cancel
> Pass activate handler dispatches an event that throws an error
> Pass activate handler throws an error that is cancelled
> Pass activate handler throws an error and prevents default
Ah looks like the update script did not remove the ini file itself after removing all the cases. I may have done something wrong there. Yes a followup bug, where the patch is simply to remove the testing/web-platform/mozilla/meta/service-workers/service-worker/onactivate-script-error.https.html.ini file should be enough.
Flags: needinfo?(nsm.nikhil)
Reporter | ||
Comment 11•9 years ago
|
||
(In reply to Nikhil Marathe [:nsm] (please needinfo?) from comment #10)
> Ah looks like the update script did not remove the ini file itself after
> removing all the cases. I may have done something wrong there. Yes a
> followup bug, where the patch is simply to remove the
> testing/web-platform/mozilla/meta/service-workers/service-worker/onactivate-
> script-error.https.html.ini file should be enough.
Follow up bug just created, please see bug 1198636. Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•