Restricted Profiles: Review new strings for profile settings UI

VERIFIED FIXED in Firefox 42

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: sebastian, Assigned: sebastian)

Tracking

unspecified
Firefox 42
Unspecified
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

Posted image restrictions-setup.png (obsolete) —
Since bug 965151 landed we allow the device admin (e.g. parent) to configure the restrictions that are enforced for a restricted profile (e.g. child). This is part of the restricted profile setup UI of the Android system. See attached screenshot how this looks like.

Every restriction can have a title and a description. The strings I added are monotonic and the description is often not very helpful or the same as the title.

These are our current strings:

> <!ENTITY restriction_disallow_import_settings_title "Disallow importing settings">
> <!ENTITY restriction_disallow_import_settings_description "Do not allow to import settings from other system browsers.">

> <!ENTITY restriction_disallow_addons_title "Disallow add-ons">
> <!ENTITY restriction_disallow_addons_description "Disallow installation of add-ons.">

> <!ENTITY restriction_disallow_devtools_title "Disallow developer tools">
> <!ENTITY restriction_disallow_devtools_description "Disallow usage of developer tools.">

> <!ENTITY restriction_disallow_customize_home_title "Disallow customizing home">
> <!ENTITY restriction_disallow_customize_home_description "Disallow customizing home panels.">

> <!ENTITY restriction_disallow_private_browsing_title "Disallow private browsing">
> <!ENTITY restriction_disallow_private_browsing_description "Disallow private browsing mode.">

> <!ENTITY restriction_disallow_location_services_title "Disallow location services">
> <!ENTITY restriction_disallow_location_services_description "Disallow sharing of location data to improve geolocation service.">

> <!ENTITY restriction_disallow_display_settings_title "Disallow display settings">
> <!ENTITY restriction_disallow_display_settings_description "Disallow changing of advanced display settings.">

> <!ENTITY restriction_disallow_clear_history_title "Disallow clearing history">
> <!ENTITY restriction_disallow_clear_history_description "Disallow clearing of browser history.">

> <!ENTITY restriction_disallow_master_password_title "Disallow master password">
> <!ENTITY restriction_disallow_master_password_description "Disallow setting a master password for logins.">


These three are still in there but are very likely going away in bug 1189414

> <!ENTITY restriction_disallow_tools_menu_title "Disallow Tools menu">
> <!ENTITY restriction_disallow_tools_menu_description "Hide Tools menu from UI.">

> <!ENTITY restriction_disallow_report_site_issue_title "Disallow \'Report site issue\'">
> <!ENTITY restriction_disallow_report_site_issue_description "Hide \'Report site issue\' menu item.">

> <!ENTITY restriction_disallow_apps_title "Disallow apps">
> <!ENTITY restriction_disallow_apps_description "Disallow installing apps from Firefox Marketplace.">
Robin, Anthony: Can you help me to come up with strings that are actually helpful and can be understood by a non-developer?
Flags: needinfo?(randersen)
Flags: needinfo?(alam)
As a general pass, I'd use "disable" instead of "disallow".

Also, "Report Site Issue" is only available on Nightly builds I think? Do we need that item called out here?

Maybe something like:

Disable add-ons installation

Disable apps installation

Hide tools menu

Hide import settings

Have you guys thought about grouping these options? "disables" and the "hides" maybe? it might make for easier messaging as well since some of these are obviously features that users want to get "just out of reach" rather than "completely hidden"
Flags: needinfo?(alam)
As collaborating in bugzilla isn't that great I created the following etherpad for this:
https://mobile.etherpad.mozilla.org/97
(In reply to Anthony Lam (:antlam) from comment #2)
> As a general pass, I'd use "disable" instead of "disallow".

Alright. I'll try to update the strings accordingly.

> Also, "Report Site Issue" is only available on Nightly builds I think? Do we
> need that item called out here?

Yeah, this one is going away. I updated the etherpad with the latest version.
Awesome, thanks Sebastian!

I left some comments and questions in the etherpad but it generally looks pretty good. 

I made the point to capitalize features names which we already do in product like but we might want to double check some of that.
(In reply to Anthony Lam (:antlam) from comment #5)
> Awesome, thanks Sebastian!
> 
> I left some comments and questions in the etherpad but it generally looks
> pretty good. 
> 
> I made the point to capitalize features names which we already do in product
> like but we might want to double check some of that.

Thank you! I tried to answer all your questions. Feel free to directly edit the titles and descriptions in place. This way it'll be easier to copy them into the project once finalized. :)
Talked to Sebastian on IRC, I think we can do without the descriptions.
Agreed, we can do without the descriptions.
Flags: needinfo?(randersen)
last call for input! srsly!
Flags: needinfo?(sfang)
Flags: needinfo?(bbermes)
Screenshot of the settings with final strings.
Attachment #8641581 - Attachment is obsolete: true
Patch with finalized title strings and removed descriptions. Anyone ready for a last-minute review for 42? :)
Attachment #8644851 - Flags: review?(mhaigh)
Attachment #8644851 - Flags: review?(margaret.leibovic)
Attachment #8644851 - Flags: review?(ally)
Comment on attachment 8644851 [details] [diff] [review]
1189680-strings.patch

Review of attachment 8644851 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but please rev the entity names before landing.

::: mobile/android/base/locales/en-US/android_strings.dtd
@@ +690,5 @@
>  <!-- Restrictions -->
>  <!-- Localization note: These are restrictions the device owner (e.g. parent) can enable for
>       a restricted profile (e.g. child). Used inside the Android settings UI. -->
> +<!ENTITY restriction_disallow_import_settings_title "Disable \'Import from Android\'">
> +<!ENTITY restriction_disallow_addons_title "Disable add-on installation">

You should rev the entity names if their contents have changed, since some localizers start working on Nightly, and their tools won't detect the new string if the entity name is the same.

Usually we just add a "2" or something to the end, and you can just update it in strings.xml.in, but leave the string resource id alone.
Attachment #8644851 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8644851 [details] [diff] [review]
1189680-strings.patch

Okay. I'll update the entity names.
Attachment #8644851 - Flags: review?(mhaigh)
Attachment #8644851 - Flags: review?(ally)
url:        https://hg.mozilla.org/integration/fx-team/rev/0c01ce7ee9feb3a29358e69656fd09cbbac84e7e
changeset:  0c01ce7ee9feb3a29358e69656fd09cbbac84e7e
user:       Sebastian Kaspari <s.kaspari@gmail.com>
date:       Fri Aug 07 18:32:01 2015 +0200
description:
Bug 1189680 - Restricted profile: Finalize title strings and remove descriptions. r=margaret
Landed. :)
Status: NEW → ASSIGNED
Flags: needinfo?(sfang)
Flags: needinfo?(bbermes)
https://hg.mozilla.org/mozilla-central/rev/0c01ce7ee9fe
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Verified that the new strings are displayed correctly on Nightly and Aurora
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.