1189822 - Remove RegisterDOMExpandoObject and associated machinery

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Right now the only way to do the preservation is to create the expando, as far as I can tell.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Switch DOMProxyHandler::EnsureExpandoObject to using normal wrapper preservation instead of RegisterDOMExpandoObject

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove the DOM proxy expando object hashtable in xpconnect

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Stop using EnsureExpandoObject in codegen code when we just want to preserver the wrapper for a DOM proxy

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Fix finalization for DOM overridebuildins proxies to not clear the expando if it's for a different reflector. sfink

This is something that should have happened in bug 1352430 but was missed there.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Remove the now-unnecessary DOMProxyHandler::ClearExternalRefsForWrapperRelease function

All DOMProxyHandler::ClearExternalRefsForWrapperRelease now does is clear a backpointer to the expando, and that's handled during reflector finalization already.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/810a380512e9
part 1.  Switch DOMProxyHandler::EnsureExpandoObject to using normal wrapper preservation instead of RegisterDOMExpandoObject.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/d820067e4d5f
part 2.  Remove the DOM proxy expando object hashtable in xpconnect.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ccd27cf7166
part 3.  Stop using EnsureExpandoObject in codegen code when we just want to preserver the wrapper for a DOM proxy.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/793ab87511f5
part 4.  Fix finalization for DOM overridebuildins proxies to not clear the expando if it's for a different reflector.  r=peterv, sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/30f6ea5ad9e6
part 5.  Remove the now-unnecessary DOMProxyHandler::ClearExternalRefsForWrapperRelease function.  r=peterv

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/810a380512e9
https://hg.mozilla.org/mozilla-central/rev/d820067e4d5f
https://hg.mozilla.org/mozilla-central/rev/5ccd27cf7166
https://hg.mozilla.org/mozilla-central/rev/793ab87511f5
https://hg.mozilla.org/mozilla-central/rev/30f6ea5ad9e6