1189852 - link broken which a line break on hash part after Bug 1144398

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[YF (Yang)]

Attachment: example

The regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=84f7fa96af4f&tochange=b6b20e7ca118

https://hg.mozilla.org/integration/mozilla-inbound/rev/c334736aa584

Firefox 37: good
Firefox 38: bad, no page be opened

Comment 1

[Valentin Gosu [:valentin] (he/him)]

According to https://url.spec.whatwg.org/#fragment-state new line (aka U+000A) isn't allowed in the fragment.
Bug 1189852 enforced that constraint, even though before we would strip whitespace characters from the end of the URL.

I'll try to fix this. Thanks for the bug report and regression window.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: link broken which a line break on hash part

I changed the code to reject only \0s in SetSpec and SetHash. \r\n\t will be stripped in SetSpec, and encoded in SetHash just as before, and similar to Chrome's behaviour (see table in Bug 1190027 comment 0)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/134cb6e4b7ea

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/134cb6e4b7ea

Comment 5

[Kohei Yoshino [:kohei]]

Added the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/link-with-line-break-in-hash-part-is-broken/