Closed Bug 1189871 Opened 4 years ago Closed 4 years ago

Add event to add/remove permissions for Graphene

Categories

(Firefox OS Graveyard :: Runtime, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
FxOS-S5 (21Aug)
Tracking Status
firefox43 --- fixed

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

Attachments

(1 file)

There should be an event in b2g/chrome/content/shell.js which wraps setting and removing permissions.

It would for example call:

Services.perms.add(slashdotURI, 'trackingprotection', Services.perms.ALLOW_ACTION);
Summary: Add API to add/remove permissions → Add event to add/remove permissions for Graphene
Attachment #8642097 - Flags: review?(fabrice)
Attachment #8642097 - Flags: review?(fabrice) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4595fcf7f37090d7799ad6478651677747dbe5c0
changeset:  4595fcf7f37090d7799ad6478651677747dbe5c0
user:       Brian R. Bondy <netzen@gmail.com>
date:       Mon Aug 10 17:00:01 2015 -0400
description:
Bug 1189871 - Add event to add/remove permissions for Graphene. r=fabrice
https://hg.mozilla.org/mozilla-central/rev/4595fcf7f370
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S5 (21Aug)
Any reason why you need to create these events than navigator.mozPermissionSettings other than both you and your reviewer does not know it exists?

https://developer.mozilla.org/en-US/docs/Web/API/PermissionSettings
Flags: needinfo?(netzen)
If it does the same and was available when this landed on larch, then no.
Flags: needinfo?(netzen)
Could you file a bug to get these event listeners removed, once you remove the dependency? It would be better if we leverage existing and testable code path.

I don't really know where this is being used...

Thanks!
Flags: needinfo?(netzen)
Depends on: 1217460
Flags: needinfo?(netzen)
Done, thanks for the suggestion.
You need to log in before you can comment on or make changes to this bug.