Closed
Bug 1189871
Opened 9 years ago
Closed 9 years ago
Add event to add/remove permissions for Graphene
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
FxOS-S5 (21Aug)
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: bbondy, Assigned: bbondy)
References
Details
Attachments
(1 file)
2.41 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
There should be an event in b2g/chrome/content/shell.js which wraps setting and removing permissions. It would for example call: Services.perms.add(slashdotURI, 'trackingprotection', Services.perms.ALLOW_ACTION);
Assignee | ||
Updated•9 years ago
|
Summary: Add API to add/remove permissions → Add event to add/remove permissions for Graphene
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8642097 -
Flags: review?(fabrice)
Updated•9 years ago
|
Attachment #8642097 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=32ace3e22c52
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dace7b1b33e
Assignee | ||
Comment 4•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/4595fcf7f37090d7799ad6478651677747dbe5c0 changeset: 4595fcf7f37090d7799ad6478651677747dbe5c0 user: Brian R. Bondy <netzen@gmail.com> date: Mon Aug 10 17:00:01 2015 -0400 description: Bug 1189871 - Add event to add/remove permissions for Graphene. r=fabrice
https://hg.mozilla.org/mozilla-central/rev/4595fcf7f370
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S5 (21Aug)
Comment 6•9 years ago
|
||
Any reason why you need to create these events than navigator.mozPermissionSettings other than both you and your reviewer does not know it exists? https://developer.mozilla.org/en-US/docs/Web/API/PermissionSettings
Flags: needinfo?(netzen)
Assignee | ||
Comment 7•9 years ago
|
||
If it does the same and was available when this landed on larch, then no.
Flags: needinfo?(netzen)
Comment 8•9 years ago
|
||
Could you file a bug to get these event listeners removed, once you remove the dependency? It would be better if we leverage existing and testable code path. I don't really know where this is being used... Thanks!
Flags: needinfo?(netzen)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(netzen)
Assignee | ||
Comment 9•9 years ago
|
||
Done, thanks for the suggestion.
You need to log in
before you can comment on or make changes to this bug.
Description
•